Bump acorn from 5.7.3 to 5.7.4 - #6
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com>
fredericd pushed a commit
that referenced
this pull request
Oct 17, 2022
Issue #6 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Author
Looks like acorn is up-to-date now, so this is no longer needed. |
fredericd pushed a commit
that referenced
this pull request
Apr 2, 2023
This simply adds a row to the config page for configuring a mapping for Control number, without this patch you cannot configure the feild, and the default is 'any' I used the first record here for testing: http://lx2.loc.gov:210/NAF?operation=searchRetrieve&version=1.1&query=query=bath.personalName=%22butler%20octavia%22&maximumRecords=20&recordSchema=marcxml Enter SRU server using settings here: https://www.loc.gov/z3950/lcserver.html#serv host: lx2.loc.gov port: 210 db: NAF userid: password: servername: LOC SRU checked: NULL rank: NULL syntax: USMARC timeout: 0 servertype: sru encoding: utf8 recordtype: authority To test: 1 - Setup SRU server using settings above 2 - In the server config click 'Modify' under 'SRU search fields mapping' 3 - Note you don't have an option for 'Control number' 4 - Go to Authorities 5 - New from Z39.50/SRU 6 - Search 'Control number' field with: PS3552.U827 7 - You get the record noted above as all fields are searched 8 - Search 'Control number' field with: 79056654 9 - You get the record noted above as all fields are searched 10 - Apply patch 11 - In the server config click 'Modify' under 'SRU search fields mapping' 12 - Note you now have a config for 'Control number' 13 - Enter 'bath.lccn' 14 - Save 15 - Repeat search from #6 - no result 16 - Repeat search from #8 - correct result as only lccn fields are search 17 - Modify server config ans set 'Control number' to 'bath.lcCallNumber' 18 - Repeat search from #6 - correct results as call number field is now search 19 - Repeast search from #8 - no result Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
fredericd pushed a commit
that referenced
this pull request
Apr 26, 2023
This simply adds a row to the config page for configuring a mapping for Control number, without this patch you cannot configure the feild, and the default is 'any' I used the first record here for testing: http://lx2.loc.gov:210/NAF?operation=searchRetrieve&version=1.1&query=query=bath.personalName=%22butler%20octavia%22&maximumRecords=20&recordSchema=marcxml Enter SRU server using settings here: https://www.loc.gov/z3950/lcserver.html#serv host: lx2.loc.gov port: 210 db: NAF userid: password: servername: LOC SRU checked: NULL rank: NULL syntax: USMARC timeout: 0 servertype: sru encoding: utf8 recordtype: authority To test: 1 - Setup SRU server using settings above 2 - In the server config click 'Modify' under 'SRU search fields mapping' 3 - Note you don't have an option for 'Control number' 4 - Go to Authorities 5 - New from Z39.50/SRU 6 - Search 'Control number' field with: PS3552.U827 7 - You get the record noted above as all fields are searched 8 - Search 'Control number' field with: 79056654 9 - You get the record noted above as all fields are searched 10 - Apply patch 11 - In the server config click 'Modify' under 'SRU search fields mapping' 12 - Note you now have a config for 'Control number' 13 - Enter 'bath.lccn' 14 - Save 15 - Repeat search from #6 - no result 16 - Repeat search from #8 - correct result as only lccn fields are search 17 - Modify server config ans set 'Control number' to 'bath.lcCallNumber' 18 - Repeat search from #6 - correct results as call number field is now search 19 - Repeast search from #8 - no result Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (cherry picked from commit 557a028) Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
fredericd pushed a commit
that referenced
this pull request
May 16, 2025
What this patch does is: 1 - Wraps the existing search code in a a "bool" compound query as a "must". This should not affect relevancy or results of the existing searches. 2 - Before we clean/truncate terms, loop through the passed in search terms and indexes to build a new 'should' query, using the 'match' on the specified index/field that is added to the 'bool' query from above. This means that if a result from the original query is also returned here, that item will be boosted in the result. For searches on 'keyword' or 'title', or if no index is set, we use 'title-cover' as the most narrow form of title This query isn't going to help when users enter CCL (i.e. ti:To die for) and it won't boost titles from 505, series, etc when doing a general search. Nor will it have a detrimental effect, it will only boost field matches To test: 1 - Add a record with 245 $a novel 2 - Add a record with 245 $a A novel : $b about things / $c by me 3 - Search for: novel - Above records are returned lower in the list (results #6 and #14 for me) 4 - Search for: a novel - Above records are returned lower in the list (results #6 and #14 for me) 5 - Apply patch, restart all, enable ESBoostFieldMatch option 6 - Repeat searches, note exact titles are boosted - For 'novel' record from #1 is #1 result and other is second - For 'a novel' record form #2 is #1 result and other is third 7 - Disable the new pref and repeat steps 3 and 4 and get results as before patch 8 - Experiment with other searches, turning pref on and off to verify relevant titles are boosted when enabled 9 - Search results when disabled should return as before the patch Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Thomas Klausner <domm@plix.at> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps acorn from 5.7.3 to 5.7.4.
Commits
6370e90Mark version 5.7.4fbc15b1More rigorously check surrogate pairs in regexp validatorDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.