feat(sponsors): add component for adding a sponsor to an event by joelrozen · Pull Request #140 · freeCodeCamp/chapter

joelrozen · 2019-10-24T06:38:24Z

#97

I have read Chapter's contributing guidelines.
My pull request has a descriptive title (not a vague title like Update README.md).
My pull request targets the master branch of Chapter.

Closes#97

adds form to add a sponsor to an event.
display sponsor on event listing page.

@vkWeb - as discussed I started this before the change to TS and I don't know TS (yet!) :(

freeCodeCamp#97

vkWeb · 2019-10-24T06:57:41Z

@joelrozen Thanks for working on this. We really need to push MVP features into the codebase ❤️

Don't worry our mods will look at it and will point any issues in the code. I'm not into React as of now so I won't be able to review this.

I'm mentioning experienced devs for review: @nik-john @timmyichen @Zeko369.

also make changes as per reviewer comments

timmyichen

Nice work! Just added a few comments, mostly around TS and TODOs. Thanks for helping out with this 🙌 🎉

timmyichen · 2019-10-24T12:22:51Z

Btw let me know if you need any help with TS, either here or on Discord 🙃

timmyichen · 2019-10-24T12:24:02Z

Oops sorry for the string of comments, but can you also revert the changes to package-lock.json since axios is no longer required? Thanks 😛

joelrozen · 2019-10-24T18:45:06Z

Oops sorry for the string of comments, but can you also revert the changes to package-lock.json since axios is no longer required? Thanks 😛

Do you want me to just add package-lock.json and yarn.lock to .gitignore?

vaibhavsingh97 · 2019-10-24T18:51:42Z

Do you want me to just add package-lock.json and yarn.lock to .gitignore?

Nope, it's needed in the project and it's recommended to present in git

nik-john · 2019-10-24T18:53:33Z

We should be using either yarn or npm, there's no need the use both. I would recommend just using npm now that it's pretty much caught up with yarn

…onents also addressed reviewer comments

…ting tests also changed error handling / success response handling

also remove return type of FC

vaibhavsingh97

LGTM, just a minor thing, move AddSponsor.tsx to Components folder in interfaces and styles.
FYR:

|
|__interfaces
| |__Components
| |_AddSponsor.tsx
|__styles
| |__Components
| |_AddSponsor.tsx

joelrozen · 2019-10-28T19:31:39Z

LGTM, just a minor thing, move AddSponsor.tsx to Components folder in interfaces and styles.
FYR:
|
|__interfaces
| |__Components
| |_AddSponsor.tsx
|__styles
| |__Components
| |_AddSponsor.tsx

done!

vaibhavsingh97

LGTM 🎉, will wait for another approval before the merge

timmyichen

Sweet! Just a few last changes and we should be good to go

timmyichen

✨

Zeko369

@timmyichen @joelrozen

QuincyLarson · 2019-11-15T19:39:58Z

Note: Per #163 we have decided to use React-hook-form.

joelrozen · 2019-11-16T04:32:54Z

I will refactor tomorrow

… project specs 163

joelrozen · 2019-11-17T00:59:08Z

@timmyichen and @QuincyLarson changes complete. Also now makes (basic) use of react-hooks-form as per #163

timmyichen

LGTM! cc @Zeko369

vaibhavsingh97

LGTM, just a minor change

vaibhavsingh97

LGTM 🎉

vaibhavsingh97 · 2019-11-17T09:24:14Z

Merging, Thanks for the PR @joelrozen 💯

phoenisx · 2019-11-17T13:55:29Z

So are we going with isomorphic-fetch then?? It hasn't been maintained for 4 years now
Ref: matthew-andrews/isomorphic-fetch#133

vaibhavsingh97 · 2019-11-17T14:19:41Z

@Shub1427 that's not the case here, please feel free to raise another PR if you want to use axios. This PR is there for long time, so i thought let's merge this and then work actively on fixing issues with PR.

joelrozen added 2 commits October 24, 2019 17:34

feat(add a sponsor): add component for adding a sponsor to an event
0f03ae6
freeCodeCamp#97

style(client): fix whitespace
6ea7e76

vkWeb requested review from nik-john and vaibhavsingh97 October 24, 2019 06:54

vkWeb requested a review from Zeko369 October 24, 2019 07:04

robertt suggested changes Oct 24, 2019
View reviewed changes

Comment threadpackage.json Outdated
Comment threadclient/components/AddSponsor.tsx Outdated
Comment threadclient/components/AddSponsor.tsx Outdated

vkWeb changed the title ~~feat(add a sponsor): add component for adding a sponsor to an event~~feat(sponsors): add component for adding a sponsor to an eventOct 24, 2019

refactor(add sponsor): convert to typescript
f82cc60
also make changes as per reviewer comments

timmyichen suggested changes Oct 24, 2019
View reviewed changes

vaibhavsingh97 reviewed Oct 24, 2019
View reviewed changes

Comment threadclient/components/AddSponsor.tsx Outdated

vaibhavsingh97 reviewed Oct 24, 2019
View reviewed changes

Comment threadpages/add-sponsor.tsx Outdated

joelrozen added 2 commits October 25, 2019 07:46

refactor(add sponsor): adding basic styling to form using styled-comp…
759aff0
…onents also addressed reviewer comments

Merge branch 'master' into feat/add-sponsor
c6f880f

timmyichen reviewed Oct 24, 2019
View reviewed changes

Comment threadclient/components/AddSponsor.tsx

timmyichen reviewed Oct 24, 2019
View reviewed changes

Comment threadclient/components/AddSponsor.tsx Outdated

joelrozen added 5 commits October 25, 2019 09:08

Merge branch 'master' into feat/add-sponsor
7d93b70

chore(add-sponsor): fix spelling mistakes
7362852

refactor(add-sponsor): add isomporphic-fetch and refactor to pass lin…
4be6d09
…ting tests also changed error handling / success response handling

fix(eslintrd): ignore prop-types in eslint
8d1ec43

fix(add sponsor component): rename interfaces to begin with 'I'
74aa3bc
also remove return type of FC

vaibhavsingh97 suggested changes Oct 26, 2019
View reviewed changes

Comment threadclient/components/AddSponsor.tsx Outdated
Comment threadclient/components/AddSponsor.tsx Outdated

refactor(add sponsor): split styles and interfaces into seperate files
bd882e4

joelrozen requested a review from vaibhavsingh97 October 28, 2019 10:17

vaibhavsingh97 reviewed Oct 28, 2019
View reviewed changes

refactor(add sponsor): folder restructure
5f859bc

joelrozen requested a review from vaibhavsingh97 October 28, 2019 19:32

vaibhavsingh97 approved these changes Oct 29, 2019
View reviewed changes

timmyichen suggested changes Oct 29, 2019
View reviewed changes

Comment threadclient/components/AddSponsor.tsx Outdated
Comment threadclient/components/AddSponsor.tsx Outdated
Comment threadclient/components/AddSponsor.tsx Outdated

joelrozenand others added 3 commits November 2, 2019 09:09

refactor(addsponsor.tsx): fix submit function to use try/catch
55fb268

Merge branch 'master' into feat/add-sponsor
2c2bffd

Update .eslintrc.json
5d2f49e

timmyichen approved these changes Nov 9, 2019
View reviewed changes

Zeko369 suggested changes Nov 9, 2019
View reviewed changes

Comment threadclient/components/AddSponsor.tsx Outdated
Comment threadclient/interfaces/components/AddSponsor.tsx Outdated
Comment threadclient/components/AddSponsor.tsx

This was referenced Nov 9, 2019
Using useReducer for form data #163
Closed
Add Redux/Thunk with bare minimum setup #166
Merged

QuincyLarson assigned timmyichen Nov 15, 2019

joelrozen added 4 commits November 17, 2019 11:27

refactor(add sponsor): make sponsor type a typed enum
5873c42

chore(rebase): merge master into branch
89939c8

refactor(add sponsor form): rewrite to use react-hook-form as per new…
cac99ba
… project specs 163

fix(eslintrc): fix merge conflicts
02b6a5c

timmyichen approved these changes Nov 17, 2019
View reviewed changes

vaibhavsingh97 suggested changes Nov 17, 2019
View reviewed changes

Comment threadclient/components/AddSponsor.tsx Outdated

Joel Rozen added 2 commits November 17, 2019 19:54

fix(add sponsor) remove console log
e62982b

fix linter being weird
4f0ab3b

vaibhavsingh97 approved these changes Nov 17, 2019
View reviewed changes

vaibhavsingh97 merged commit 8bcfd3b into freeCodeCamp:masterNov 17, 2019

phoenisx mentioned this pull request Nov 24, 2019
Decide which SSR Data Fetching Library to use #258
Closed

Uh oh!

Uh oh!

Conversation

joelrozen commented Oct 24, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkWeb commented Oct 24, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timmyichen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timmyichen commented Oct 24, 2019

Uh oh!

timmyichen commented Oct 24, 2019

Uh oh!

joelrozen commented Oct 24, 2019

Uh oh!

vaibhavsingh97 commented Oct 24, 2019

Uh oh!

nik-john commented Oct 24, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vaibhavsingh97 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joelrozen commented Oct 28, 2019

Uh oh!

vaibhavsingh97 left a comment

Choose a reason for hiding this comment

Uh oh!

timmyichen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timmyichen left a comment

Choose a reason for hiding this comment

Uh oh!

Zeko369 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

QuincyLarson commented Nov 15, 2019

Uh oh!

joelrozen commented Nov 16, 2019

Uh oh!

joelrozen commented Nov 17, 2019

Uh oh!

timmyichen left a comment

Choose a reason for hiding this comment

Uh oh!

vaibhavsingh97 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vaibhavsingh97 left a comment

Choose a reason for hiding this comment

Uh oh!

vaibhavsingh97 commented Nov 17, 2019

joelrozen commented Oct 24, 2019•
edited
Loading

vaibhavsingh97 left a comment •
edited
Loading