Skip to content
This repository was archived by the owner on Sep 25, 2025. It is now read-only.

feat: Add columns to control notification flow - #374

Merged
Zeko369 merged 4 commits into
freeCodeCamp:masterfrom
davidals:notification-migrations
Mar 19, 2020
Merged

feat: Add columns to control notification flow#374
Zeko369 merged 4 commits into
freeCodeCamp:masterfrom
davidals:notification-migrations

Conversation

@davidals

@davidalsdavidals commented Mar 16, 2020

Copy link
Copy Markdown
Contributor

Needed in order to implements featured mentioned on issues #107, #276, #359

  • I have read Chapter's contributing guidelines.
  • My pull request has a descriptive title (not a vague title like Update README.md).
  • My pull request targets the master branch of Chapter.

Closes #XXXXX

Needed in order to implements featured mentioned on issues freeCodeCamp#107, freeCodeCamp#276, freeCodeCamp#359
Comment threadserver/models/UserChapter.ts Outdated
@Column({ nullable: false })
interested: boolean;

constructor(params: { user: User; chapter: Chapter }) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add interested as a optional param, but default it to true

Comment threadserver/models/Rsvp.ts
@Column({ nullable: false })
interested: boolean;

constructor(params: {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add interested as a optional param, but default it to true

Comment threadserver/migrations/1584377551030-AddCancelledColumnToRsvp.ts Outdated
Comment threadserver/migrations/1584377249878-AddInterestedColumnToUserChapter.ts Outdated

@allellaallella left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple minor questions and points.

Comment threadserver/migrations/1584377551030-AddCancelledColumnToRsvp.ts Outdated
@davidals

Copy link
Copy Markdown
ContributorAuthor

Addressed your comments @Zeko369 and @allella

@allella

Copy link
Copy Markdown
Contributor

I'm good. @Zeko369 you ready to merge ?

@Zeko369
Zeko369 merged commit 8a5ddd1 into freeCodeCamp:masterMar 19, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@davidals@allella@Zeko369