Skip to content
This repository was archived by the owner on Sep 25, 2025. It is now read-only.

Update DOCS - #396

Merged
vkWeb merged 4 commits into
freeCodeCamp:masterfrom
Zeko369:updateDocs
Oct 11, 2020
Merged

Update DOCS#396
vkWeb merged 4 commits into
freeCodeCamp:masterfrom
Zeko369:updateDocs

Conversation

@Zeko369

@Zeko369Zeko369 commented Aug 3, 2020•
edited by vkWeb
Loading

Copy link
Copy Markdown
Contributor

A lot of changes, pending first check

  • Remove redux
    • Docs
    • Implementation
  • Move from REST -> GQL
    • Docs
    • Implementation
  • Split app into 2
    • Docs
    • Implementation
  • Change seeding system
    • Docs
    • Implementation
  • Refactor docker setup
    • Docs
    • Implementation
  • General docs and README
    • Tech stack in readme
    • New workflow

@Zeko369
Zeko369 marked this pull request as draft August 3, 2020 21:48
@Zeko369Zeko369 self-assigned this Aug 3, 2020
@allellaallella added the Documentation Improvements or additions to documentation label Aug 4, 2020
@tomiiide

tomiiide commented Aug 4, 2020

Copy link
Copy Markdown
Contributor

@Zeko369 Splitting the app into 2, what does that mean?

What are the implications of that for a one-click installation setup for the end users?

@Zeko369

Zeko369 commented Aug 8, 2020

Copy link
Copy Markdown
ContributorAuthor

@tomiiide I setup a script to boot up the app in production mode that we'll use to for example on heroku (so only one dyno)

@allella

allella commented Sep 1, 2020

Copy link
Copy Markdown
Contributor

@Zeko369 I'm still planning to move most of technical details out of the README and into the CONTRIBUTING.md.

The summary of technology in this draft makes sense in the README in this draft.

Is there more you'd like to change on the PR, or shall we merge it in so the README reflects the revised tech stack?

@allellaallella mentioned this pull request Sep 13, 2020
Merged
3 tasks
@allella

allella commented Sep 16, 2020

Copy link
Copy Markdown
Contributor

@Zeko369 someone asked about the role of Jest and it's referenced in #366. Perhaps that's worth inclusion in the docs.

@vkWeb
vkWeb marked this pull request as ready for review October 11, 2020 00:53
@vkWeb

vkWeb commented Oct 11, 2020

Copy link
Copy Markdown
Member

@Zeko369 I am pushing some docs update here as I just did a fresh installation of chapter (I got Ubuntu). Then once this is merged we can put on remaining docs update in future PRs.

@vkWeb
Merge branch 'master' into pr-396
accd1e1
Making this branch to match upstream latest.
Merge branch 'master' into pr-396
Making this branch to match upstream latest.
@vkWeb
Add root package-lock.json
5549784
@vkWeb
docs: move all tech to contributing
aa57d9e
@vkWeb

vkWeb commented Oct 11, 2020

Copy link
Copy Markdown
Member

@Zeko369 I'm merging this we can revisit more docs update later.

@vkWeb
vkWeb merged commit 3b20e32 into freeCodeCamp:masterOct 11, 2020
@allellaallella mentioned this pull request Mar 8, 2021
Closed
8 tasks
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@Zeko369Zeko369

Labels

DocumentationImprovements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Zeko369@tomiiide@allella@vkWeb