Skip to content
This repository was archived by the owner on Sep 25, 2025. It is now read-only.

Move server/docs/README.md into CONTRIBUTING.md, per Quincy - #397

Merged
allella merged 14 commits into
freeCodeCamp:masterfrom
allella:docs/move-server-notes-to-contributing
Aug 15, 2020
Merged

Move server/docs/README.md into CONTRIBUTING.md, per Quincy#397
allella merged 14 commits into
freeCodeCamp:masterfrom
allella:docs/move-server-notes-to-contributing

Conversation

@allella

@allellaallella commented Aug 14, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Closes nothing.

Per Quincy's suggestion to consolidate docs into the Wiki and Contributing.md
and #360 had to do the following:

  • Added volunteer roles to existing CONTRIBUTING.md table
  • moved server/docs/README.md to the end of CONTRIBUTING.md

@Zeko369 holler if this is going to cause a merge conflict or if any of the contents of server/docs/README.md are no longer relevant after the recent rework.

@allellaallella added the Documentation Improvements or additions to documentation label Aug 14, 2020
@allellaallella mentioned this pull request Aug 15, 2020
Closed
8 tasks
Zeko369
Zeko369 suggested changes Aug 15, 2020
View reviewed changes
Comment threadCONTRIBUTING.md Outdated
Comment threadCONTRIBUTING.md Outdated
Comment threadCONTRIBUTING.md Outdated
Comment threadCONTRIBUTING.md Outdated
Comment threadCONTRIBUTING.md Outdated
Comment threadCONTRIBUTING.md Outdated
Comment threadCONTRIBUTING.md Outdated
Comment threadCONTRIBUTING.md Outdated
Comment threadCONTRIBUTING.md Outdated
Comment threadCONTRIBUTING.md
| Name | GitHub | Twitter |
|:----------------|:-------|:--------|
| Quincy Larson | [`@QuincyLarson`](https://github.com/QuincyLarson) | [`@ossia`](https://twitter.com/ossia)|
| Name | GitHub | Role |

@Zeko369Zeko369Aug 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allella I would extract this into README.md

@allellaallellaAug 15, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this into CONTRIBUTING.md and we'll consider moving to README

@Zeko369

Zeko369 commented Aug 15, 2020

Copy link
Copy Markdown
Contributor

@allella I'm pretty sure I don't have access to your repo (opening a PR there seems like to much work), so I added some inline suggestions for ServerSideDocs updates

allellaand others added 10 commits August 15, 2020 12:30
@allella@Zeko369
Update CONTRIBUTING.md
67e6811
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
@allella@Zeko369
Update CONTRIBUTING.md
a7f7da2
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
@allella@Zeko369
Update CONTRIBUTING.md
c3f0938
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
@allella@Zeko369
Update CONTRIBUTING.md
4338c3e
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
@allella@Zeko369
Update CONTRIBUTING.md
5c8dc23
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
@allella@Zeko369
Update CONTRIBUTING.md
690d6d1
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
@allella@Zeko369
Update CONTRIBUTING.md
7a65974
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
@allella@Zeko369
Update CONTRIBUTING.md
cc3c4ce
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
@allella@Zeko369
Update CONTRIBUTING.md
b0cb6aa
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
@allella@Zeko369
Update CONTRIBUTING.md
f53fda4
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
@allella
allella merged commit 86b836e into freeCodeCamp:masterAug 15, 2020
@allella
allella deleted the docs/move-server-notes-to-contributing branch August 15, 2020 16:34
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@Zeko369Zeko369Zeko369 requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DocumentationImprovements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@allella@Zeko369