Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Sep 25, 2025. It is now read-only.
remove yarn.lock; changed README.md to include npm install for client - #402
Closed
paulywill wants to merge 1 commit into
Closed
remove yarn.lock; changed README.md to include npm install for client#402paulywill wants to merge 1 commit into
npm install for client#402paulywill wants to merge 1 commit into
Conversation
| Install dependencies: | ||
| ``` | ||
| npm install | ||
| npm install && cd client && npm install && cd .. |
Contributor
There was a problem hiding this comment.
Maybe we can split this command into separate lines:
npm install
cd client
npm install // client packages (someone can give a better desc here...)
No need for the cd .. I think.
Contributor
Just one note. Also, your |
paulywill
commented
Sep 15, 2020
MemberAuthor
Ack'd I'll close this PR and open a new one with just the README edit. |
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update README.md).masterbranch of Chapter.Troubleshooting errors with
docker-compose upon OSX (10.13.6)someone in the Discord mentioned to resolve this you have to
cd client && npm installAdded the missing instruction to the README.md
Instead of individual commands, I strung them together with
&&.:npm install && cd client && npm install && cd ..Since quite of bit of the README kept indicating using
npm install, I removed the yarn.lock file and instead included the package-lock.json