Skip to content
This repository was archived by the owner on Sep 25, 2025. It is now read-only.

feat: email users on venue change - #642

Merged
ojeytonwilliams merged 8 commits into
freeCodeCamp:mainfrom
ojeytonwilliams:feat/email-users-on-venue-change
Aug 19, 2021
Merged

feat: email users on venue change#642
ojeytonwilliams merged 8 commits into
freeCodeCamp:mainfrom
ojeytonwilliams:feat/email-users-on-venue-change

Conversation

@ojeytonwilliams

@ojeytonwilliamsojeytonwilliams commented Jun 25, 2021

Copy link
Copy Markdown
Contributor

This emails the users that have RVSP'd whenever the venue is changed.

Currently the tests only check that the venue change happens and that emails about it are sent. It does not, yet, confirm that only the RVSPs get emailed, but I plan to circle back to that test later.

Closes#663

@gitpod-io

gitpod-ioBot commented Jun 25, 2021

Copy link
Copy Markdown

@allella

Copy link
Copy Markdown
Contributor

@ojeytonwilliams this seems like a smart idea. I'm not sure we have an MVP issue for it, but if you already have it worked up, then we can create a user story if needed.

Also, I think it would be helpful to link the PRs to the MVP issue / story if it's not too much trouble.

Thanks and nice work.

@ojeytonwilliams

Copy link
Copy Markdown
ContributorAuthor

Sounds good. I've been focusing on the features that @Zeko369 outlined for the demo video, since they seemed both urgent and good things to have in the MVP.

And, yes, I agree these should all be linked to MVP issues and stories. I'll add all of those for the PRs I've recently created.

@ojeytonwilliams
ojeytonwilliamsforce-pushed the feat/email-users-on-venue-change branch from 102a626 to 6f66293CompareJuly 9, 2021 13:58
@ojeytonwilliams

Copy link
Copy Markdown
ContributorAuthor

Given that this adds a single organizer to the db, I think this should wait until we've decided on and implemented the ideas discussed here: #641 (comment)

@ojeytonwilliams
ojeytonwilliams marked this pull request as draft July 9, 2021 15:25
@ojeytonwilliams
ojeytonwilliamsforce-pushed the feat/email-users-on-venue-change branch 2 times, most recently from fafb95d to 27a6fbfCompareAugust 12, 2021 15:58
@ojeytonwilliams
ojeytonwilliams marked this pull request as ready for review August 12, 2021 16:07
@ojeytonwilliams

Copy link
Copy Markdown
ContributorAuthor

There are no longer any changes to the db, since the recently added user_event_roles table captures the relationship I was trying to add with the organizer.

@ojeytonwilliams
ojeytonwilliamsforce-pushed the feat/email-users-on-venue-change branch from 27a6fbf to 7078692CompareAugust 19, 2021 09:32
@ojeytonwilliams
ojeytonwilliams merged commit b73f65e into freeCodeCamp:mainAug 19, 2021
@ojeytonwilliams
ojeytonwilliams deleted the feat/email-users-on-venue-change branch August 19, 2021 10:28
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

As a user, when an organizer changes an event's venue, I will receive an email if I have RSVP'd

3 participants

@ojeytonwilliams@allella@Zeko369