Skip to content
This repository was archived by the owner on Sep 25, 2025. It is now read-only.

Added functionality to send Email to selected Group of People - #712

Merged
ojeytonwilliams merged 6 commits into
freeCodeCamp:mainfrom
Ravichandra-C:email_participants
Sep 27, 2021
Merged

Added functionality to send Email to selected Group of People#712
ojeytonwilliams merged 6 commits into
freeCodeCamp:mainfrom
Ravichandra-C:email_participants

Conversation

@Ravichandra-C

@Ravichandra-CRavichandra-C commented Sep 23, 2021

Copy link
Copy Markdown
Contributor
  • I have read Chapter's contributing guidelines.
  • My pull request has a descriptive title (not a vague title like Update README.md).
  • My pull request targets the main branch of Chapter.

Closes#99

i. Server

1. resolver.ts
Modified the sendEventInvite Resolver to take an
emailGroup as optional argument.

ii. Client
1. Added New argument in method definitions in graphql.tsx
2. Created a new Modal component to show the checkboxes for
selecting the group
3. Added a button in Actions components to show the Modal
component

RaviRavi
Added functionality to send Email to selected Group of People
a1e22c2
i. Server
1. resolver.ts
Modified the sendEventInvite Resolver to take an
emailGroup as optional argument.
ii. Client
1. Added New argument in method definitions in graphql.tsx
2. Created a new Modal component to shoqw the checkboxes for
seleting the group
3. Added a button in Actions components to show the Modal
componenet
@gitpod-io

gitpod-ioBot commented Sep 23, 2021

Copy link
Copy Markdown

@Ravichandra-CRavichandra-C mentioned this pull request Sep 24, 2021
Closed
ojeytonwilliams
ojeytonwilliams suggested changes Sep 24, 2021
View reviewed changes

@ojeytonwilliamsojeytonwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Ravichandra-C, I just want to start by saying this some really nice work. I know that I've nitpicked quite a bit, but that's all it is.

Anyways, thanks again for all your hard work and I hope the review comments make sense.

Comment threadclient/src/modules/dashboard/Events/components/SendEmailModal.tsx Outdated
Comment threadclient/src/modules/dashboard/Events/components/SendEmailModal.tsx Outdated
Comment threadclient/src/modules/dashboard/Events/components/SendEmailModal.tsx Outdated
Comment threadclient/src/modules/dashboard/Events/components/SendEmailModal.tsx Outdated
Comment threadclient/src/modules/dashboard/Events/components/SendEmailModal.tsx Outdated
Comment threadclient/src/modules/dashboard/Events/components/SendEmailModal.tsx Outdated
Comment threadserver/src/controllers/Events/resolver.ts
Comment threadserver/src/controllers/Events/resolver.ts Outdated
Comment threadserver/src/controllers/Events/resolver.ts
Comment threadserver/src/controllers/Events/resolver.ts Outdated
RaviRavi
Updated the Code based on the PR review
48b7378
1. sendEmailModal.tsx
1. Created the Interface of FormInputs
2. Used the interface in useForm
3. renamed the metho to atleastOneChecked
4. Removed the Extra error message in atleastonechecked
5. Removed defaultChecked
2. resolver.ts
1. Added the strict type Checking in emailGroups Parameter
2. Removed the console.log
@Ravichandra-C

Ravichandra-C commented Sep 24, 2021

Copy link
Copy Markdown
ContributorAuthor

@ojeytonwilliams ,Thanks a lot for your feedback. I've made all the suggested changes except the part in server/src/controllers/Events/resolver.ts where we are using interested .

Please let me know your thoughts on this.

ojeytonwilliams
ojeytonwilliams suggested changes Sep 27, 2021
View reviewed changes

@ojeytonwilliamsojeytonwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nitpick, but otherwise LGTM 👍

Comment threadclient/src/modules/dashboard/Events/components/SendEmailModal.tsx Outdated
Comment threadserver/src/controllers/Events/resolver.ts
@Ravichandra-C

Ravichandra-C commented Sep 27, 2021

Copy link
Copy Markdown
ContributorAuthor

@ojeytonwilliams , I've updated the message in Modal . Can you please review it once?

@ojeytonwilliams

ojeytonwilliams commented Sep 27, 2021

Copy link
Copy Markdown
Contributor

Nice work, @Ravichandra-C, let's get this in 🚀

@ojeytonwilliams

ojeytonwilliams commented Sep 27, 2021

Copy link
Copy Markdown
Contributor

Ooops, misclicked 🤦‍♂️

@ojeytonwilliams
ojeytonwilliams merged commit f72989d into freeCodeCamp:mainSep 27, 2021
@allella

allella commented Oct 15, 2021

Copy link
Copy Markdown
Contributor

@all-contributors add @Ravichandra-C for code

@allcontributorsallcontributorsBot mentioned this pull request Oct 15, 2021
Merged
@allcontributors

allcontributorsBot commented Oct 15, 2021

Copy link
Copy Markdown
Contributor

@allella

I've put up a pull request to add @Ravichandra-C! 🎉

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ojeytonwilliamsojeytonwilliamsojeytonwilliams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

As an organizer I can email the entire list of participants.

3 participants

@Ravichandra-C@ojeytonwilliams@allella