Skip to content
This repository was archived by the owner on Sep 25, 2025. It is now read-only.

fix: sponsor fields should not be empty - #849

Merged
ojeytonwilliams merged 7 commits into
freeCodeCamp:mainfrom
gikf:fix/sponsors-form-defaults
Jan 12, 2022
Merged

fix: sponsor fields should not be empty#849
ojeytonwilliams merged 7 commits into
freeCodeCamp:mainfrom
gikf:fix/sponsors-form-defaults

Conversation

@gikf

@gikfgikf commented Jan 9, 2022•
edited
Loading

Copy link
Copy Markdown
Member
  • I have read Chapter's contributing guidelines.
  • My pull request has a descriptive title (not a vague title like Update README.md).
  • My pull request targets the main branch of Chapter.

Still required:

  • Clean up

Closes#846

  • Disables Add button, when all existing sponsors are added.
  • When adding new sponsor, default sponsor type and sponsor are selected from still available sponsors.
  • Available sponsor types and sponsors are limited based on selections in other fields.
  • Moves default sponsor types to utils.
  • Moves functions getting allowed sponsors, sponsor types to utils.
  • Any notes are appreciated.
  • Tested on local fork.

@gitpod-io

gitpod-ioBot commented Jan 9, 2022

Copy link
Copy Markdown

@ghost

ghost commented Jan 9, 2022•
edited by ghost
Loading

Copy link
Copy Markdown

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@gikf
gikf marked this pull request as ready for review January 11, 2022 09:28
ojeytonwilliams
ojeytonwilliams suggested changes Jan 12, 2022
View reviewed changes

@ojeytonwilliamsojeytonwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! The sponsor form is really smooth now. I found a few places where I felt there was a little too much abstraction, but that was it - the code's solid.

Comment threadclient/src/modules/dashboard/Events/components/EventFormUtils.ts Outdated
Comment threadclient/src/modules/dashboard/Events/components/EventFormUtils.ts Outdated
Comment threadclient/src/modules/dashboard/Events/components/EventFormUtils.ts Outdated
Comment threadclient/src/modules/dashboard/Events/components/EventFormUtils.ts Outdated
Comment threadclient/src/modules/dashboard/Events/components/EventFormUtils.ts Outdated
gikf
gikf commented Jan 12, 2022
View reviewed changes

@gikfgikf left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking 👍, suggestions are on-point 🚀

Comment threadclient/src/modules/dashboard/Events/components/EventFormUtils.ts Outdated
gikfand others added 2 commits January 12, 2022 12:19
@gikf@ojeytonwilliams
fix: apply suggestions from code review
fcd282e
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
@gikf
fix: line lint
755bb5d
ojeytonwilliams
ojeytonwilliams approved these changes Jan 12, 2022
View reviewed changes

@ojeytonwilliamsojeytonwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers @gikf. This LGTM 👍

@ojeytonwilliams
ojeytonwilliams merged commit d43bcf5 into freeCodeCamp:mainJan 12, 2022
@gikf
gikf deleted the fix/sponsors-form-defaults branch January 12, 2022 11:49
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ojeytonwilliamsojeytonwilliamsojeytonwilliams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Default sponsor fields should not be empty

2 participants

@gikf@ojeytonwilliams