Separate init scripts

[fozzmoo]

This commit improves handling of PID files, creates separate init scripts for each of the services traditionally started by the freeside init script, and removes the freeside init script.

[freeside]

In the Makefile:

• Local path changes are included along with the changes you intended.
• Excessively copied and pasted sections that substitute values into the new init scripts. Instead of that, the current init script sources /etc/default/freeside -- have all the new ones do as well. The values can be defined there.

In the init scripts:

• A bunch of code duplication defining the same functions in different scripts. This should be cleaned up.
• /var/lock/subsys/ appears to be RHEL/CentOS-specific
• The torrus script assumes collector_main_0. If you look at the current script, we have found that not to be the case reliably.

[fozzmoo]

Amended the pull request with new commits to address Ivan's comments.

[freeside]

Amended the pull request with new commits to address Ivan's comments.

A large number of your local changes are still included in the Makefile.

/etc/rc.d/init.d/ is a Red Hat-only path and is hardcoded.

Almost every init file is the same except for one line. You should generate them from a common template, not add a dozen identical files.

[fozzmoo]

• Removed highlighted "local changes" in Makefile
• Templatized multiple init scripts and included logic in Makefile to render them at make-time.
• Changed /etc/rc.d/init.d, indeed a RHELism, to /etc/init.d

[freesidejeremy]

I have evaluated the changes so far and here are the issues I have encountered:

1.) There are still RHEL references in the Makefile
#RHEL and derivatives
#APACHE_CONF = /etc/httpd/conf.d
If this item is needed, we should work out a way for the Makefile can handle this automatically, without having to add in it commented, then un-commenting when needed.

2.) INIT_INSTALL_X commands for installing the new init file is using RHEL/Fedora specific commands, specifically chkconfig.

[freesidejeremy]

Hello folks,

We're doing 4.0 release preparations, and as a big change, if this doesn't make 4.0 it won't be in until 5.x. Willl you be able to look into the feedback shortly? If you want us to do this work instead, please let us know.

[freesidejeremy]

Hello folks,

We're doing 4.0 release preparations, and as a big change, if this doesn't make 4.0 it won't be in until 5.x. Willl you be able to look into the feedback shortly? If you want us to do this work instead, please let us know.