Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cube.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ void loadColorPlaneZ(
}

// Disable 7154, MY9262 latch complete
PORTE |= (1 << 6); // digitalWrite(PIN_LED_EN, HIGH);
// PORTE |= (1 << 6); // digitalWrite(PIN_LED_EN, HIGH); // mjh
PORTD &= ~(1 << 6); // digitalWrite(PIN_LED_LAT, LOW);

byte colorPlaneZSelect = color + (planeZ * 3);
Expand All @@ -189,7 +189,7 @@ void loadColorPlaneZ(
PORTB |= (colorPlaneZSelect << 4);

// Enable 74154
PORTE &= ~(1 << 6); // digitalWrite(PIN_LED_EN, LOW);
// PORTE &= ~(1 << 6); // digitalWrite(PIN_LED_EN, LOW);

// Re-enable SPI hardware if it was enabled
if(spe_set)
Expand Down
2 changes: 1 addition & 1 deletion color.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#define COLOR_h

typedef struct {
byte color[3];
int color[3];
}
rgb_t;

Expand Down
4 changes: 2 additions & 2 deletions parser.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ static const byte RBRAC = 0x29; // Right bracket ')'
typedef struct command_s {
char *name;
byte (*parser) (
char *message,
const char *message,
byte length,
byte *position,
struct command_s *command,
Expand All @@ -42,7 +42,7 @@ command_t commands[] = {
"set", parseCommandSet, executeNop,
"next", parseCommandNext, executeNop,
"line", parseCommandLine, executeNop,
"box", parseCommandBox, executeNop,
"box", parseCommandBox, executeNop,
"sphere", parseCommandSphere, executeNop,
"setplane", parseCommandSetplane, executeNop,
"copyplane", parseCommandCopyplane, executeNop,
Expand Down
20 changes: 20 additions & 0 deletions readmeMJH.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
steps to be taken to allow this example to work :
this file will be updated as I progress and recover the data from experience.

1. Download and install the Arduino IDE { we are now at version 1.8.5 }

2. when attempting to build errors will occur due to missing file Cube.h . To fix this we need the library

2.1 Download the ZIP from the freetronics github repo site (even on Linux) and unzip into "libraries" in the tree where the IDE was installed.

3. restart the IDE - fine but the compiler enforces stricter rules now than when the example was created.

4. Note : I already had a fork of the repo in ECA.

5. So I removed the "unzipped" file from the repo as it has no version control and used the repo from the ECA user in github. I changed the files to make the compilation work and will now investigate further to merge them, when acceptable, into the mastaer...

6. There are still several warnings at compile time with the Cube code. I will attempt to fix them.

7. be aware that if you repeat the compilation then with some environment settings the warnings will 'go away' and it will appear clean...


3 changes: 2 additions & 1 deletion serial.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,11 @@ void Cube::serialBegin(
serial = & Serial;
break;

case 1:
/* case 1:
Serial1.begin(baudRate);
serial = & Serial1;
break;
*/ // mjh
}

if (serial) {
Expand Down