Custom base URL support, configurable by environment variable - #40
Custom base URL support, configurable by environment variable#40conroy-cheers wants to merge 5 commits into
Conversation
freyta
commented
Nov 9, 2019
I'm not quite sure what the point of this is? I don't know what use this would be for the majority of people. Excuse my ignorance. |
NGPriest
commented
Nov 9, 2019
I would agree with @freyta with this PR... |
conroy-cheers
commented
Nov 10, 2019
Use case is when running it behind a proxy, at e.g. my.domain.com/proxy_path/ - by configuring the app to use /proxy_path/ as the base URL, all the links and static files will work properly. Much cleaner than getting the proxy server to rewrite URLs in the HTML. |
beaudeanadams
commented
Dec 16, 2019
This may be somewhat related to #47 iirc |
conroy-cheers
commented
Dec 16, 2019
I did some (admittedly quick) research and from what I saw, using a blueprint seemed to be the cleanest solution, as it functions similarly to the default I’m open to suggestions though - I’m far from an expert on Flask. If there’s another method you’d prefer, I could take a look at implementing it instead. |
# Conflicts: # app.py
NGPriest
commented
Jan 1, 2020
Do they really have honeypots? :S I mean, if someone happened to live locally and locked in the "special" price, do they expect to get banned? |
# Conflicts: # app.py # templates/index.html
No description provided.