-
-
Notifications
You must be signed in to change notification settings - Fork 28
fix(sentry): bound transport memory usage #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
src/sentry/src/Listener/RequestContextLifecycleListener.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
| /** | ||
| * This file is part of friendsofhyperf/components. | ||
| * | ||
| * @link https://github.com/friendsofhyperf/components | ||
| * @document https://github.com/friendsofhyperf/components/blob/main/README.md | ||
| * @contact huangdijia@gmail.com | ||
| */ | ||
|
|
||
| namespace FriendsOfHyperf\Sentry\Listener; | ||
|
|
||
| use Hyperf\Event\Contract\ListenerInterface; | ||
| use Hyperf\HttpServer\Event as HttpEvent; | ||
| use Hyperf\RpcServer\Event as RpcEvent; | ||
| use Sentry\SentrySdk; | ||
|
|
||
| use function Hyperf\Coroutine\defer; | ||
|
|
||
| class RequestContextLifecycleListener implements ListenerInterface | ||
| { | ||
| public function listen(): array | ||
| { | ||
| return [ | ||
| HttpEvent\RequestReceived::class, | ||
| RpcEvent\RequestReceived::class, | ||
| ]; | ||
| } | ||
|
|
||
| public function process(object $event): void | ||
| { | ||
| $previousContext = SentrySdk::getCurrentRuntimeContext(); | ||
| SentrySdk::startContext(); | ||
|
|
||
| if (SentrySdk::getCurrentRuntimeContext() === $previousContext) { | ||
| return; | ||
| } | ||
|
|
||
| // Register cleanup before the remaining request listeners add their deferred | ||
| // callbacks. Coroutine defers run in LIFO order, so the context is ended last. | ||
| defer(static fn () => SentrySdk::endContext()); | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
在新 PHP 文件头中添加许可证信息。
当前文件头只包含项目链接和联系信息。请添加项目许可证声明。
src/sentry/src/Listener/RequestContextLifecycleListener.php#L4-L10:添加项目许可证信息。tests/Sentry/RequestContextLifecycleListenerTest.php#L4-L10:添加相同的项目许可证信息。As per coding guidelines,所有 PHP 文件头必须包含许可证信息。
📍 Affects 2 files
src/sentry/src/Listener/RequestContextLifecycleListener.php#L4-L10(this comment)tests/Sentry/RequestContextLifecycleListenerTest.php#L4-L10🤖 Prompt for AI Agents
Source: Coding guidelines