Wrong IsConstructor, IsEffectivelySameAs results for constructors in compiled code

[auduchinok]

In example below mfv is a MemberOrFunctionOrValue in a type in a compiled assembly.

if (mfv.IsConstructor) {
 var entity = mfv.EnclosingEntity;
 var hasSameMember =
 entity.MembersFunctionsAndValues.Any(m => m.IsEffectivelySameAs(mfv));
 var hasCtor =
 entity.MembersFunctionsAndValues.Any(m => m.IsConstructor);
}

Both hasSameMember and hasCtor are false while expected to be true.

I'm using FSharp.Compiler.Service 12.0.2.

[dsyme]

@auduchinok Any chance you could send a PR adding a failing test? With the repro above we won't be certain we've solved the problem.

[auduchinok]

@dsyme Sure! I'll try to write a proper test for this case and send a PR then.
One thing that I discovered while were debugging is that this reproduces for constructors in compiled code only while it works properly for types defined in the same project.

[dsyme]

@auduchinok Thanks, that would be very helpful

[auduchinok]

I couldn't reproduce it in tests, but managed to fix both issues in #777.