Uh oh!
There was an error while loading. Please reload this page.
add this missing FSIStrings Embedded Resource - #753
Merged
Conversation
dsyme
commented
Apr 10, 2017
Contributor
Looking at the OSX build, we annoyingly seem to be getting duplicate resources. I haven't yet determined why - duplicates aren't appearing when the same FSharp.Compiler.Tools targets file is being used in the fsharp/fsharp builds. Very strange to have this problem back. |
dsyme
commented
Apr 10, 2017
Contributor
This change itself is good, so I will merge this, but we need to get to the bottom of why the duplicates are happening |
matthid
commented
Apr 12, 2017
Contributor
Thanks for this :) |
dsyme added a commit
to dsyme/FSharp.Compiler.Service
that referenced
this pull request
Jun 28, 2017
Integrate visualfsharp master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@matthid This should add the resource back in.