Uh oh!
There was an error while loading. Please reload this page.
allow for generic trait calls - #30
Open
kevmal wants to merge 2 commits into
Open
Conversation
- avoid InvokeMember which does not support generic methods - remove exit call from ProcessCommandLine to allow for testing - Define generic parameters prior to resolving types on method emit
dsyme
commented
Jan 11, 2021
Contributor
Cool thanks! Any idea why CI was failing on Windows? I'm re-running it now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current version fails with missing method exception on op
-->(DiffSharp). This is becauseEvalTraitCallInvokeusesInvokeMemberwhich does not support generic methods. As an alternative type parameters are matched, generic methods are created andType.DefaultBinder.BindToMethodis then called directly.This change alone fixes the diffsharp shape checking on
-->. To add a testexitneeded to be removed fromProcessCommandLineotherwise the failing test causes the test host process to exit. Furthermore since the test is not using a method in an external assembly, phase4 ofEmitInterpretExpressionneeded to be updated to add generic parameters to the env prior to resolving parameter and return types.