Uh oh!
There was an error while loading. Please reload this page.
[Repo Assist] test: add SideEffects module to TaskSeq.CompareWith.Tests.fs - #399
Merged
dsyme merged 2 commits intoApr 21, 2026
Conversation
Add a SideEffects module with 4 new test scenarios covering: - Both sources consumed exactly once when sequences are equal - Early exit: sources consumed only 1 element each when first comparison differs - TestSideEffectTaskSeq variants for compareWith and compareWithAsync Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dsyme
marked this pull request as ready for review
April 21, 2026 10:09
Uh oh!
There was an error while loading. Please reload this page.
dsyme
deleted the
repo-assist/test-comparewith-sideeffects-20260421-eefc487d4b74f6c1
branch
April 21, 2026 10:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant.
Summary
TaskSeq.CompareWith.Tests.fshad a comprehensiveEmptySeqandImmutablemodule but was missing aSideEffectsmodule — unlike most other test files in the suite.This PR adds a
SideEffectsmodule with 4 new test scenarios:New tests
compareWith consumes both sequences exactly once when equal: Uses inline counters to verify each source is enumerated fully and exactly once across the full comparison.compareWith stops consuming sources after first non-zero comparison: Verifies the early-exit behaviour: when the first pair of elements differs,compareWithadvances each enumerator only once (the pre-loopMoveNextAsync) and does not read further elements.compareWith two fresh side-effect sequences compare as equal(TestSideEffectTaskSeqvariants): Two independent calls togetSeqWithSideEffectboth yield1..10; their comparison should be0.compareWithAsync two fresh side-effect sequences compare as equal(TestSideEffectTaskSeqvariants): Same as above but for the async comparer overload.Test growth
Test Status
dotnet build src/FSharp.Control.TaskSeq.sln -c Release— succeeded (0 warnings, 0 errors)dotnet test --filter CompareWith -c Release— 76 passeddotnet fantomas . --check— passed