Uh oh!
There was an error while loading. Please reload this page.
[Repo Assist] test: add SideEffects module to TaskSeq.WithCancellation.Tests.fs - #410
Merged
dsyme merged 2 commits intoMay 1, 2026
Conversation
Adds three tests that verify TaskSeq.withCancellation preserves the re-iteration semantics of the underlying sequence: - Applied multiple times (Theory over all side-effect variants): each iteration yields the next batch of values from the source, confirming withCancellation is a transparent wrapper that does not cache state. - Applied multiple times with an active CancellationToken: same as above but with a live CancellationToken, verifying the token is threaded through correctly without disrupting re-iteration. - Evaluates each source element exactly once per iteration: mutable counter confirms the side effect runs exactly N times per pass (no duplication or skipping). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 26, 2026
dsyme
marked this pull request as ready for review
May 1, 2026 17:19
Uh oh!
There was an error while loading. Please reload this page.
dsyme
deleted the
repo-assist/test-withcancellation-sideeffects-20260426-0dfeab7a31817c9a
branch
May 1, 2026 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant.
Summary
Adds a
module SideEffectstoTaskSeq.WithCancellation.Tests.fswith three new tests:withCancellationis a transparent wrapper — re-iterating the wrapped sequence advances side effects the same way as re-iterating the source directlyCancellationTokenSource, verifying the token does not interfere with re-iterationThe Theory tests use
TestSideEffectTaskSeqdata, running over all side-effect sequence variants (sequential, async, nested, spin-wait, etc.) consistent with the rest of the test suite.Test Status
(previously 10 WithCancellation tests; +17 new)
Full suite: 5251 passed, 0 failed (release build, net10.0).
Fantomas: ✅ clean