Uh oh!
There was an error while loading. Please reload this page.
Fixed ID type deserialization - #410
Open
xperiandri wants to merge 5 commits into
Open
Conversation
xperiandriforce-pushed
the
ID_type_deserialization_fix
branch
from
December 7, 2022 03:57
d9061cf to
8fd8170Comparexperiandri
commented
Dec 15, 2022
xperiandri
left a comment
CollaboratorAuthor
There was a problem hiding this comment.
@njlr any opinions?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
xperiandriforce-pushed
the
ID_type_deserialization_fix
branch
from
December 16, 2022 14:49
a024d30 to
48c7715Comparexperiandri
commented
Dec 17, 2022
CollaboratorAuthor
@njlr review, please |
xperiandriforce-pushed
the
ID_type_deserialization_fix
branch
from
December 17, 2022 20:32
48c7715 to
d2a746eComparemickhansen
commented
Dec 28, 2022
Collaborator
How did this fail prior to this PR? |
njlr
commented
Dec 30, 2022
Contributor
LGTM 👍 |
ivelten
commented
Jan 11, 2023
Collaborator
@njlr can you approve again? I accidentally closed the Pull Request. |
njlr
commented
Jan 11, 2023
Contributor
@ivelten I don't have permissions @xperiandri Can you help? |
xperiandri
commented
Jan 12, 2023
CollaboratorAuthor
This needs to be rebased or applied on top of #418 |
xperiandriforce-pushed
the
ID_type_deserialization_fix
branch
from
February 24, 2023 15:52
ee9baf6 to
5e02ca2Comparexperiandriforce-pushed
the
dev
branch
4 times, most recently
from
November 5, 2023 23:05
c8b3525 to
0810527Comparexperiandriforce-pushed
the
dev
branch
2 times, most recently
from
February 15, 2024 20:39
14aa27a to
3ba4016Comparexperiandriforce-pushed
the
dev
branch
2 times, most recently
from
February 25, 2024 13:02
1737829 to
246d6c0Comparexperiandriforce-pushed
the
dev
branch
2 times, most recently
from
March 24, 2024 17:56
0dd4372 to
81bc85eComparexperiandriforce-pushed
the
ID_type_deserialization_fix
branch
from
September 2, 2024 12:58
5e02ca2 to
99dc46bComparexperiandriforce-pushed
the
ID_type_deserialization_fix
branch
from
September 10, 2024 20:25
99dc46b to
8f459abComparexperiandriforce-pushed
the
dev
branch
5 times, most recently
from
October 11, 2024 16:35
d90f0e9 to
434b4beComparexperiandriforce-pushed
the
dev
branch
3 times, most recently
from
December 1, 2025 00:26
f3a1bf8 to
9d4b950Comparexperiandriforce-pushed
the
dev
branch
2 times, most recently
from
December 19, 2025 02:20
6dc591e to
85a9d8cCompareDeserialization of ID types caused an exception if the field was nullable.
xperiandriforce-pushed
the
ID_type_deserialization_fix
branch
from
June 13, 2026 18:28
8f459ab to
f3cc3dbComparexperiandri
commented
Jun 13, 2026
CollaboratorAuthor
@copilot type provider tests must be only in the integration tests project |
Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
Contributor
Done in 70fd40b: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #262