Uh oh!
There was an error while loading. Please reload this page.
Implemented ScalarDefinition<'Primitive, 'Val>, fixed built-in scalars input coercion - #439
Conversation
mickhansen
commented
Aug 28, 2023
Would it be possible to add some tests over |
xperiandri
commented
Aug 28, 2023
Good point, I'll add. |
I agree with @mickhansen regarding the question about the purpose of |
xperiandri
commented
Aug 28, 2023
Probably it can become |
valbers
left a comment
There was a problem hiding this comment.
Please address the open points and then I can approve your PR.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
mickhansen
commented
Aug 29, 2023
That sounds like a good usecase! Just wasn't familiar with the |
xperiandri
commented
Sep 12, 2023
@valbers your comments are resolved. Thanks for the very valuable feedback! |
cd9fd00 to
bdce208Comparee6e8ea6 to
cd057d6CompareScalarDefinition<'Primitive, 'Val>, fixed built-in scalars input coercion… fixed built-in scalars input coercion and added tests for that
Co-authored-by: Valber M. Silva de Souza <valbers@gmail.com>
a5b6743 to
4940832Compare
ScalarDefinition<'Primitive, 'Val>IDTypeimplementation to support only string and int64 Ids