Skip to content

Switched to rent an array in Giraffe handler - #469

Open
xperiandri wants to merge 1 commit into
devfrom
giraffe_allocation_free_check_for_empty_body
Open

Switched to rent an array in Giraffe handler#469
xperiandri wants to merge 1 commit into
devfrom
giraffe_allocation_free_check_for_empty_body

Conversation

@xperiandri

Copy link
Copy Markdown
Collaborator

Looking at allocations seems like an improvement.
Probably the time is not comparable if my machine was loaded differently during runs.

New

MethodMeanErrorStdDevMedianMinMaxOp/sGen0Gen1Allocated
BenchmarkSimpleQueryUnparsed93.97 us0.984 us0.921 us93.69 us92.67 us95.34 us10,641.62.3193-19 KB
BenchmarkSimpleQueryParsed114.89 us5.955 us17.466 us119.22 us85.92 us150.19 us8,703.91.0986-9.56 KB
BenchmarkSimpleQueryPlanned43.56 us2.285 us6.665 us42.20 us33.68 us60.05 us22,957.30.9155-7.58 KB
BenchmarkFlatQueryUnparsed296.69 us10.119 us29.034 us285.64 us261.22 us375.81 us3,370.57.3242-63.06 KB
BenchmarkFlatQueryParsed246.00 us4.903 us13.255 us241.75 us230.02 us287.13 us4,065.15.3711-47.15 KB
BenchmarkFlatQueryPlanned180.46 us3.587 us7.164 us179.69 us170.01 us198.97 us5,541.45.12700.244143.77 KB
BenchmarkNestedQueryUnparsed438.59 us4.732 us4.195 us438.19 us432.38 us446.10 us2,280.020.50780.4883169.34 KB
BenchmarkNestedQueryParsed393.96 us7.863 us13.563 us387.65 us377.57 us425.99 us2,538.314.64840.4883120.07 KB
BenchmarkNestedQueryPlanned344.46 us6.842 us17.292 us340.46 us315.08 us394.41 us2,903.113.1836-109.41 KB
BenchmarkFilteredQueryUnparsed198.84 us3.941 us7.206 us196.93 us188.97 us218.31 us5,029.16.8359-56.48 KB
BenchmarkFilteredQueryParsed158.51 us3.165 us3.767 us157.44 us152.62 us166.04 us6,308.83.4180-29.16 KB
BenchmarkFilteredQueryPlanned117.62 us4.301 us12.271 us114.44 us98.69 us153.09 us8,502.12.8076-23.67 KB

Old

MethodMeanErrorStdDevMinMaxOp/sGen0Gen1Allocated
BenchmarkSimpleQueryUnparsed83.25 us1.649 us1.543 us81.07 us87.04 us12,011.62.3193-19 KB
BenchmarkSimpleQueryParsed68.27 us1.306 us1.282 us66.59 us70.87 us14,647.61.0986-9.56 KB
BenchmarkSimpleQueryPlanned29.32 us0.535 us0.418 us28.60 us30.07 us34,111.60.9155-7.58 KB
BenchmarkFlatQueryUnparsed233.03 us2.654 us2.482 us228.53 us235.83 us4,291.27.3242-63.07 KB
BenchmarkFlatQueryParsed210.31 us2.704 us2.529 us206.20 us214.19 us4,755.05.61520.244147.11 KB
BenchmarkFlatQueryPlanned162.98 us1.722 us1.610 us161.00 us165.93 us6,135.85.12700.244143.77 KB
BenchmarkNestedQueryUnparsed398.08 us2.335 us1.950 us394.31 us401.22 us2,512.120.50780.4883169.34 KB
BenchmarkNestedQueryParsed350.29 us3.153 us2.633 us347.09 us356.82 us2,854.814.64840.4883120.07 KB
BenchmarkNestedQueryPlanned299.97 us2.615 us2.184 us295.74 us303.87 us3,333.713.1836-109.41 KB
BenchmarkFilteredQueryUnparsed173.42 us2.713 us2.538 us169.62 us177.50 us5,766.26.8359-56.48 KB
BenchmarkFilteredQueryParsed140.57 us2.723 us2.913 us135.77 us146.48 us7,114.03.4180-29.16 KB
BenchmarkFilteredQueryPlanned92.81 us1.503 us1.332 us90.71 us95.11 us10,774.72.8076-23.67 KB

@xperiandri
xperiandri requested a review from valbersMarch 25, 2024 00:08

@valbersvalbers left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@xperiandri@valbers