Skip to content

Deprecate some functions in Validation - #248

Merged
wallymathieu merged 8 commits into
fsprojects:masterfrom
wallymathieu:deprecate-validation-fn-since-it-less-generic-than-intended
Jan 24, 2020
Merged

Deprecate some functions in Validation#248
wallymathieu merged 8 commits into
fsprojects:masterfrom
wallymathieu:deprecate-validation-fn-since-it-less-generic-than-intended

Conversation

@wallymathieu

@wallymathieuwallymathieu commented Jan 23, 2020

Copy link
Copy Markdown
Member

No description provided.

@gustygusty changed the title Deprecate validate method since it's less generic than intended[WIP] Deprecate some functions in ValidationJan 23, 2020
gusty
gusty reviewed Jan 23, 2020
View reviewed changes
Comment threadsrc/FSharpPlus/Validations.fs Outdated
@gusty

gusty commented Jan 23, 2020

Copy link
Copy Markdown
Member

We can also take the opportunity to rename (and deprecate) both orElse and valueOr as they should be aligned with the recent naming (which at the same time is aligned with the existing F# core functions) defaultValue and defaultWith.

gusty
gusty reviewed Jan 23, 2020
View reviewed changes
Comment threadsrc/FSharpPlus/Validations.fs Outdated
@gusty

gusty commented Jan 23, 2020

Copy link
Copy Markdown
Member

All green. Please Squash and Merge at your convenience.

@wallymathieu

wallymathieu commented Jan 24, 2020

Copy link
Copy Markdown
MemberAuthor

Thanks @gusty for the help!

@wallymathieuwallymathieu changed the title [WIP] Deprecate some functions in ValidationDeprecate some functions in ValidationJan 24, 2020
@wallymathieu
wallymathieu merged commit a76958b into fsprojects:masterJan 24, 2020
@gustygusty mentioned this pull request Nov 18, 2022
Draft
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gustygustygusty left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wallymathieu@gusty