Skip to content

+ DateOnly and TimeOnly as Monoid - #550

Open
gusty wants to merge 10 commits into
masterfrom
gus/date-and-time
Open

+ DateOnly and TimeOnly as Monoid#550
gusty wants to merge 10 commits into
masterfrom
gus/date-and-time

Conversation

@gusty

Copy link
Copy Markdown
Member

The idea is to have some nice properties enabled, as long as they make sense.

@gusty
gustyforce-pushed the master branch 2 times, most recently from c718153 to 3962979CompareOctober 8, 2023 07:27
@gusty
gusty marked this pull request as ready for review October 13, 2023 06:56
@gustygusty changed the title + DateOnly as Monoid and Zero for TimeOnly+ DateOnly and TimeOnly as MonoidOct 14, 2023
@gusty
gustyforce-pushed the master branch 2 times, most recently from 4b42fc0 to 21f4a0bCompareOctober 14, 2023 06:49
@gusty
gustyforce-pushed the master branch 2 times, most recently from 9b34ece to b2f3c8cCompareOctober 15, 2023 05:01
@gusty
gustyforce-pushed the master branch 2 times, most recently from 484cff5 to 142c806CompareDecember 18, 2023 08:18
@gusty
gustyforce-pushed the master branch 6 times, most recently from eef4e98 to f2e49baCompareSeptember 18, 2024 07:45
@gusty

Copy link
Copy Markdown
MemberAuthor

After cooling down this PR for a while, I see things clearly now.
DateOnly shouldn't be a Monoid. Eventually it could be made an Affine Space with int.

On the other hand, TimeOnly makes total sense as a modulo 24 hours Monoid.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@gusty@wallymathieu