Skip to content

cleanup & fixes & general improvements - #1

Merged
gauron99 merged 2 commits into
mainfrom
push-vrrzxxrmqkrn
Jan 23, 2026
Merged

cleanup & fixes & general improvements#1
gauron99 merged 2 commits into
mainfrom
push-vrrzxxrmqkrn

Conversation

@gauron99

@gauron99gauron99 commented Jan 20, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator
  • code cleanup & improvement
  • more workflow tests
  • custom optional binary URL
  • pin deps to specific versions

@gauron99
gauron99force-pushed the push-vrrzxxrmqkrn branch 4 times, most recently from 96c687a to 19abfa8CompareJanuary 20, 2026 19:59
twoGiants
twoGiants requested changes Jan 21, 2026
View reviewed changes

@twoGiantstwoGiants left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! 😸 👍

Awesome to have tests now and the code reads much better!

Now that this action is taken care off, I can chime in on more improvements 😁

Core things I found:

  • curl will download 404 pages with wrong versions => can be fixed
  • cmdConstructAndRun can be named better a do a bit more
  • optional: binary url source could be a variable with a github release page default

Comment threadindex.js Outdated
Comment threadindex.js Outdated
Comment threadindex.js Outdated
Comment threadindex.js Outdated
Comment threadindex.js Outdated
Comment threadpackage.json Outdated
Comment threadindex.js
Comment threadindex.js Outdated
Comment thread.github/workflows/test-action.yml
Comment thread.github/workflows/test-action.yml
@gauron99gauron99 changed the title cleanup & fixes for function actioncleanup & fixes & general improvements for function actionJan 23, 2026
@gauron99gauron99 changed the title cleanup & fixes & general improvements for function actioncleanup & fixes & general improvementsJan 23, 2026
twoGiants
twoGiants approved these changes Jan 23, 2026
View reviewed changes

@twoGiantstwoGiants left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Approved! 😸 👍

You removed the node_modules too, that is very good. They are installed when the action is added to a workflow, right?

@gauron99
gauron99 merged commit 675fe07 into mainJan 23, 2026
7 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twoGiantstwoGiantstwoGiants approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gauron99@twoGiants