Skip to content

Fix query params 'league' and 'nation' used in Core.club() - #452

Open
yuesong wants to merge 1 commit into
futapi:masterfrom
yuesong:master
Open

Fix query params 'league' and 'nation' used in Core.club()#452
yuesong wants to merge 1 commit into
futapi:masterfrom
yuesong:master

Conversation

@yuesong

Copy link
Copy Markdown

This PR fixes query param names used in Core.club() that don't work for FUT 19. An example API call captured in Chrome looks like this:

https://utas.external.s2.fut.ea.com/ut/game/fifa19/club?sort=asc&type=player&level=bronze&team=650&league=10&nation=34&position=RB&start=0&count=91&_=1548437016376

Note the correct league and nation params in the above URL.

@codecov-io

codecov-io commented Jan 25, 2019

Copy link
Copy Markdown

Codecov Report

Merging #452 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #452 +/- ##
=======================================
Coverage 51.72% 51.72% =======================================
Files 9 9 Lines 464 464 Branches 39 39 =======================================
Hits 240 240 Misses 221 221 Partials 3 3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3792c9e...9aee911. Read the comment docs.

@jimmyyou

Copy link
Copy Markdown

I have the same observation. Looking forward to merging this PR.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@yuesong@codecov-io@jimmyyou