fix(firestore): reject undeclared update keys, support typed dotted field paths

[fwal]

Fixes #63

Repository.update encoded through the model's update struct, which strips excess keys. A Firestore field path like 'metaData.deleted' was silently dropped and the SDK rejected the empty payload with an unrelated error.

• All repository request encoders use onExcessProperty: 'error': undeclared keys in add/set/update fail with SchemaError naming the key.
• Empty update payload fails with FirestoreError code invalid-argument.
• update accepts dotted field paths, typed via UpdateData<T>. Each path resolves to its leaf schema in Model.update (through Struct, Model.Struct, Class, Record, optional, OptionalDeletable) and encodes on its own, so nested sentinels and transforms work.

yield* repo.update(id, { 'metaData.deleted': true });
yield* repo.update(id, { 'stats.likes': Firestore.increment(1) });

Behavior change: junk keys previously dropped now error.

🤖 Generated with Claude Code

[greptile-apps]

Greptile Summary

The PR makes repository request encoding strict and adds typed dotted-field updates with leaf-schema encoding and optional merge flattening.

• Undeclared request keys now fail with a descriptive SchemaError.
• Nested updates support typed dotted paths, transforms, sentinels, optional fields, records, and bounded recursive schemas.
• Empty updates fail early with an invalid-argument FirestoreError.
• Migration and repository documentation explain the behavior change and nested-update semantics.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; both previously reported issues are fixed by the current migration guidance and constrained Record-key validation.

Important Files Changed

Filename	Overview
packages/effect-firebase/src/lib/firestore/model/update-path.ts	Adds bounded typed field-path resolution, constrained Record-key validation, and merge-payload flattening; the previously reported Record validation issue is fixed.
packages/effect-firebase/src/lib/firestore/model/repository.ts	Routes dotted update keys through leaf encoders, strictly validates ordinary fields, rejects empty payloads, and supports merge flattening.
packages/effect-firebase/src/lib/firestore/model/fetch.ts	Applies strict excess-property checking consistently to repository request encoders.
packages/effect-firebase/MIGRATION.md	Documents the strict-encoding breaking change, dotted paths, whole-map replacement, and merge-mode migration guidance.
packages/effect-firebase/src/lib/firestore/model/update-path.spec.ts	Covers nested schema traversal, constrained Record keys, recursive depth limits, merge flattening, and type-level path behavior.
packages/effect-firebase/src/lib/firestore/model/repository.spec.ts	Exercises strict request validation, dotted leaf encoding, sentinels, Record paths, merge semantics, and empty-update handling.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Repository.update] --> B{merge enabled?}
  B -->|Yes| C[Flatten nested plain objects]
  B -->|No| D[Keep supplied keys]
  C --> E{Dotted field path?}
  D --> E
  E -->|Resolvable| F[Encode with leaf schema]
  E -->|Not resolvable| G[Strict struct encoding]
  F --> H[Build Firestore payload]
  G --> H
  H --> I{Payload empty?}
  I -->|Yes| J[Fail invalid-argument]
  I -->|No| K[Firestore update]

Loading

_{Reviews (4): Last reviewed commit: "feat(firestore): add { merge: true } to ..." | Re-trigger Greptile}

Dismissed because a newer commit was pushed; Greptile will re-review the current head.