converted fractional_part_rounding_thresholds to use an array of u32s - #3604
Closed
SystemPanic wants to merge 1 commit into
Closed
SystemPanic wants to merge 1 commit into
SystemPanic wants to merge 1 commit into
Conversation
Signed-off-by: Javier <25750030+SystemPanic@users.noreply.github.com>
Contributor
|
Thank you for your contribution. If you can't wait for the next fmt release, you can use an external fmt instead of the fmt bundled in spdlog. |
Author
|
@tt4g Sure, no problem. I already have a temporary patch for FlashInfer that fix it automatically. Feel free to close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSVC fails to compile format.h with "character value is out of range" errors.
PR is the same already merged on fmtlib/fmt#4719