Uh oh!
There was an error while loading. Please reload this page.
use a Julia function in PKGMAN_DownloadURL - #117
Merged
fingolfin merged 1 commit intoMar 20, 2023
Conversation
The Julia package GAP.jl provides an interface between GAP and Julia. It uses PackageManager for installing and loading GAP packages. As soon as GAP has access to a Julia session, a natural way to download files is via the Julia package Downloads.jl. Therefore, GAP.jl had replaced `PKGMAN_DownloadURL` by a Julia function that uses this approach. Since pull request gap-system/gap#5375 got merged, we can use its new feature such that the PackageManager package can perform this replacement under the condition that GAP.jl is available in the GAP session.
Codecov Report
@@ Coverage Diff @@## master #117 +/- ##
=======================================
Coverage 83.23% 83.23% =======================================
Files 4 4 Lines 1020 1020 =======================================
Hits 849 849 Misses 171 171 |
fingolfin
approved these changes
Mar 20, 2023
james-d-mitchell pushed a commit
to james-d-mitchell/PackageManager
that referenced
this pull request
Mar 20, 2026
Bumps [jupyterlab](https://github.com/jupyterlab/jupyterlab) from 4.3.3 to 4.5.3. - [Release notes](https://github.com/jupyterlab/jupyterlab/releases) - [Changelog](https://github.com/jupyterlab/jupyterlab/blob/main/RELEASE.md) - [Commits](https://github.com/jupyterlab/jupyterlab/compare/@jupyterlab/lsp@4.3.3...@jupyterlab/lsp@4.5.3) --- updated-dependencies: - dependency-name: jupyterlab dependency-version: 4.5.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Julia package GAP.jl provides an interface between GAP and Julia. It uses PackageManager for installing and loading GAP packages. As soon as GAP has access to a Julia session, a natural way to download files is via the Julia package Downloads.jl.
Therefore, GAP.jl had replaced
PKGMAN_DownloadURLby a Julia function that uses this approach.Since pull request gap-system/gap#5375 got merged, we can use its new feature such that the PackageManager package can perform this replacement under the condition that GAP.jl is available in the GAP session.
(The proposed code is simply ignored by versions of GAP that do not yet have the abovementioned feature.)
@fingolfin Do you have perhaps some comments?