Uh oh!
There was an error while loading. Please reload this page.
Require GAP >= 4.13 - #13
Merged
Merged
Conversation
The `Extensions` field in PackageInfo.g, which we use to load gap/digraphs.g once Digraphs is available, is only supported since GAP 4.13 (see gap-system/gap#5375). Older GAP versions silently ignore unknown PackageInfo.g components, so on GAP 4.11/4.12 the extension is never read, QC_RegisterFilterGen(IsDigraph, ...) never runs, and tst/digraphs.tst fails with Error, Filter with no random generator: <Category "IsDigraph"> The previous bound of ">= 4.11" was never actually tested, since the CI matrix hardcoded stable-4.13 as its oldest branch. Testing against the 'minimal' GAP version derived from PackageInfo.g exposed this.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #13 +/- ##
=======================================
Coverage 84.87% 84.87% =======================================
Files 4 4 Lines 205 205 =======================================
Hits 174 174 Misses 31 31 🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
fingolfin added a commit
that referenced
this pull request
Jul 31, 2026
The `Extensions` field in PackageInfo.g, which we use to load gap/digraphs.g once Digraphs is available, is only supported since GAP 4.13 (see gap-system/gap#5375). Older GAP versions silently ignore unknown PackageInfo.g components, so on GAP 4.11/4.12 the extension is never read, QC_RegisterFilterGen(IsDigraph, ...) never runs, and tst/digraphs.tst fails with Error, Filter with no random generator: <Category "IsDigraph"> The previous bound of ">= 4.11" was never actually tested, since the CI matrix hardcoded stable-4.13 as its oldest branch. Testing against the 'minimal' GAP version derived from PackageInfo.g exposed this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Extensionsfield in PackageInfo.g, which we use to loadgap/digraphs.g once Digraphs is available, is only supported since
GAP 4.13 (see gap-system/gap#5375). Older GAP versions silently
ignore unknown PackageInfo.g components, so on GAP 4.11/4.12 the
extension is never read, QC_RegisterFilterGen(IsDigraph, ...) never
runs, and tst/digraphs.tst fails with
The previous bound of ">= 4.11" was never actually tested, since the
CI matrix hardcoded stable-4.13 as its oldest branch. Testing against
the 'minimal' GAP version derived from PackageInfo.g exposed this.