Support on_*_entry, on_*_exit and implicit callback methods being private. - #37
Support on_*_entry, on_*_exit and implicit callback methods being private.#37danp wants to merge 1 commit into
on_*_entry, on_*_exit and implicit callback methods being private.#37Conversation
geekq
commented
Oct 21, 2011
My concern is the compatibility to different Ruby versions. I intend the workflow library to work with Ruby 1.8.6, 1.8.7 and 1.9.*. I remember the old discussions like http://deaddeadgood.com/2008/11/17/rubys-send-method/ |
danp
commented
Oct 25, 2011
Understood. According to this, 1.8.6 through 1.9.2 support According to this (and from what I recall, need to do some digging in the source history to verify), only 1.9.1 has the It's arguable the behavior for 1.9.1 users would be unchanged; though if they saw in the documentation private methods were supported they would be confused when it didn't work for them. If it's possible, would you be ok with a solution that used |
danp
commented
Oct 6, 2012
korny
commented
May 28, 2013
Actually, #53 only fixed this for implicit callbacks, but not for |
korny
commented
May 28, 2013
Pull request is in #81. |
Passing
trueas the second argument torespond_to?searches methods that have been markedprivateas well. This patch adds that so callback methods can be private.