Skip to content

Fix 4 issues in codegen - #387

Merged
fantix merged 3 commits into
masterfrom
codegen-fix
Nov 2, 2022
Merged

Fix 4 issues in codegen#387
fantix merged 3 commits into
masterfrom
codegen-fix

Conversation

@fantix

@fantixfantix commented Oct 26, 2022•
edited
Loading

Copy link
Copy Markdown
Member
  • Add missing std::json
  • Support optional argument
  • Fix camelcase generation
  • Allow symlinks in project dir

@fantix
Fix 3 issues in codegen
2e311d6
* Add missing std::json
* Support optional argument
* Fix camelcase generation
@fantix
fantix requested a review from 1st1October 26, 2022 22:57
@1st1

1st1 commented Oct 28, 2022

Copy link
Copy Markdown
Member

@fantix can you separate the std::json fix into a separate PR? We need to ponder a bit on it.

@fantix
fantix marked this pull request as draft October 31, 2022 14:59
@fantix

fantix commented Oct 31, 2022

Copy link
Copy Markdown
MemberAuthor

can you separate the std::json fix into a separate PR? We need to ponder a bit on it.

@1st1 done in #388

1st1
1st1 approved these changes Nov 1, 2022
View reviewed changes
@1st1

1st1 commented Nov 1, 2022

Copy link
Copy Markdown
Member

Looks good overall, Fantix

@fantix
fantix marked this pull request as ready for review November 2, 2022 19:23
@fantix
fantix merged commit a912511 into masterNov 2, 2022
@fantix
fantix deleted the codegen-fix branch November 2, 2022 20:40
fantix added a commit that referenced this pull request Nov 2, 2022
@fantix
edgedb-python 1.1.0
7d63029
Codegen Fixes
=============
* Add missing std::json (#387)
* Support optional argument (#387)
* Fix camelcase generation (#387)
* Allow symlinks in project dir (#387)
* Use Executor on generated code for Client/Tx (#390)
@fantixfantix changed the title Fix 3 issues in codegenFix 4 issues in codegenNov 2, 2022
@fantixfantix mentioned this pull request Nov 2, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st11st11st1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fantix@1st1