Fix an error in string representation of RelativeDuration. by vpetrovykh · Pull Request #453 · geldata/gel-python

vpetrovykh · 2023-07-24T22:34:11Z

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative.

Also add test cases for similar situtation with other duration types.

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

msullivan

Well that is some fun.

It might be worth at some point exposing these hours/minutes/second components directly. Seems a shame to go through all of this trouble only to expose them via string formatting

vpetrovykh · 2023-07-24T23:09:53Z

It might be worth at some point exposing these hours/minutes/second components directly. Seems a shame to go through all of this trouble only to expose them via string formatting

Yeah, we probably want some nice getters or just @property for those at some point.

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

@elprans

Changes ======= * Implement support for new type descriptor protocol (by @elprans in 47eec19 for #427) * Sync errors (by @elprans in 3bfb574 for #449) * Don't depend on exact syntax errors in tests (by @msullivan in b3ce0c6 for #451) * Fix an error in string representation of RelativeDuration. (by @vpetrovykh in 667da72 for #453) * Add multirange support. (by @vpetrovykh in 15e280e for #452)

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

@elprans

Changes ======= * Implement support for new type descriptor protocol (by @elprans in 47eec19 for #427) * Sync errors (by @elprans in 3bfb574 for #449) * Don't depend on exact syntax errors in tests (by @msullivan in b3ce0c6 for #451) * Fix an error in string representation of RelativeDuration. (by @vpetrovykh in 667da72 for #453) * Add multirange support. (by @vpetrovykh in 15e280e for #452)

vpetrovykh · 2023-07-24T22:34:11Z

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative.

Also add test cases for similar situtation with other duration types.

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

msullivan

Well that is some fun.

It might be worth at some point exposing these hours/minutes/second components directly. Seems a shame to go through all of this trouble only to expose them via string formatting

vpetrovykh · 2023-07-24T23:09:53Z

It might be worth at some point exposing these hours/minutes/second components directly. Seems a shame to go through all of this trouble only to expose them via string formatting

Yeah, we probably want some nice getters or just @property for those at some point.

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

@elprans

Changes ======= * Implement support for new type descriptor protocol (by @elprans in 47eec19 for #427) * Sync errors (by @elprans in 3bfb574 for #449) * Don't depend on exact syntax errors in tests (by @msullivan in b3ce0c6 for #451) * Fix an error in string representation of RelativeDuration. (by @vpetrovykh in 667da72 for #453) * Add multirange support. (by @vpetrovykh in 15e280e for #452)

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

@elprans

Changes ======= * Implement support for new type descriptor protocol (by @elprans in 47eec19 for #427) * Sync errors (by @elprans in 3bfb574 for #449) * Don't depend on exact syntax errors in tests (by @msullivan in b3ce0c6 for #451) * Fix an error in string representation of RelativeDuration. (by @vpetrovykh in 667da72 for #453) * Add multirange support. (by @vpetrovykh in 15e280e for #452)

vpetrovykh · 2023-07-24T22:34:11Z

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative.

Also add test cases for similar situtation with other duration types.

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

msullivan

Well that is some fun.

It might be worth at some point exposing these hours/minutes/second components directly. Seems a shame to go through all of this trouble only to expose them via string formatting

vpetrovykh · 2023-07-24T23:09:53Z

It might be worth at some point exposing these hours/minutes/second components directly. Seems a shame to go through all of this trouble only to expose them via string formatting

Yeah, we probably want some nice getters or just @property for those at some point.

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

@elprans

Changes ======= * Implement support for new type descriptor protocol (by @elprans in 47eec19 for #427) * Sync errors (by @elprans in 3bfb574 for #449) * Don't depend on exact syntax errors in tests (by @msullivan in b3ce0c6 for #451) * Fix an error in string representation of RelativeDuration. (by @vpetrovykh in 667da72 for #453) * Add multirange support. (by @vpetrovykh in 15e280e for #452)

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

@elprans

Changes ======= * Implement support for new type descriptor protocol (by @elprans in 47eec19 for #427) * Sync errors (by @elprans in 3bfb574 for #449) * Don't depend on exact syntax errors in tests (by @msullivan in b3ce0c6 for #451) * Fix an error in string representation of RelativeDuration. (by @vpetrovykh in 667da72 for #453) * Add multirange support. (by @vpetrovykh in 15e280e for #452)

vpetrovykh · 2023-07-24T22:34:11Z

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative.

Also add test cases for similar situtation with other duration types.

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

msullivan

Well that is some fun.

It might be worth at some point exposing these hours/minutes/second components directly. Seems a shame to go through all of this trouble only to expose them via string formatting

vpetrovykh · 2023-07-24T23:09:53Z

It might be worth at some point exposing these hours/minutes/second components directly. Seems a shame to go through all of this trouble only to expose them via string formatting

Yeah, we probably want some nice getters or just @property for those at some point.

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

@elprans

Changes ======= * Implement support for new type descriptor protocol (by @elprans in 47eec19 for #427) * Sync errors (by @elprans in 3bfb574 for #449) * Don't depend on exact syntax errors in tests (by @msullivan in b3ce0c6 for #451) * Fix an error in string representation of RelativeDuration. (by @vpetrovykh in 667da72 for #453) * Add multirange support. (by @vpetrovykh in 15e280e for #452)

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

@elprans

Changes ======= * Implement support for new type descriptor protocol (by @elprans in 47eec19 for #427) * Sync errors (by @elprans in 3bfb574 for #449) * Don't depend on exact syntax errors in tests (by @msullivan in b3ce0c6 for #451) * Fix an error in string representation of RelativeDuration. (by @vpetrovykh in 667da72 for #453) * Add multirange support. (by @vpetrovykh in 15e280e for #452)

vpetrovykh · 2023-07-24T22:34:11Z

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative.

Also add test cases for similar situtation with other duration types.

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

msullivan

Well that is some fun.

It might be worth at some point exposing these hours/minutes/second components directly. Seems a shame to go through all of this trouble only to expose them via string formatting

vpetrovykh · 2023-07-24T23:09:53Z

It might be worth at some point exposing these hours/minutes/second components directly. Seems a shame to go through all of this trouble only to expose them via string formatting

Yeah, we probably want some nice getters or just @property for those at some point.

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

@elprans

Changes ======= * Implement support for new type descriptor protocol (by @elprans in 47eec19 for #427) * Sync errors (by @elprans in 3bfb574 for #449) * Don't depend on exact syntax errors in tests (by @msullivan in b3ce0c6 for #451) * Fix an error in string representation of RelativeDuration. (by @vpetrovykh in 667da72 for #453) * Add multirange support. (by @vpetrovykh in 15e280e for #452)

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

@elprans

Changes ======= * Implement support for new type descriptor protocol (by @elprans in 47eec19 for #427) * Sync errors (by @elprans in 3bfb574 for #449) * Don't depend on exact syntax errors in tests (by @msullivan in b3ce0c6 for #451) * Fix an error in string representation of RelativeDuration. (by @vpetrovykh in 667da72 for #453) * Add multirange support. (by @vpetrovykh in 15e280e for #452)

vpetrovykh · 2023-07-24T22:34:11Z

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative.

Also add test cases for similar situtation with other duration types.

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

msullivan

Well that is some fun.

It might be worth at some point exposing these hours/minutes/second components directly. Seems a shame to go through all of this trouble only to expose them via string formatting

vpetrovykh · 2023-07-24T23:09:53Z

It might be worth at some point exposing these hours/minutes/second components directly. Seems a shame to go through all of this trouble only to expose them via string formatting

Yeah, we probably want some nice getters or just @property for those at some point.

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

@elprans

Changes ======= * Implement support for new type descriptor protocol (by @elprans in 47eec19 for #427) * Sync errors (by @elprans in 3bfb574 for #449) * Don't depend on exact syntax errors in tests (by @msullivan in b3ce0c6 for #451) * Fix an error in string representation of RelativeDuration. (by @vpetrovykh in 667da72 for #453) * Add multirange support. (by @vpetrovykh in 15e280e for #452)

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

@elprans

Changes ======= * Implement support for new type descriptor protocol (by @elprans in 47eec19 for #427) * Sync errors (by @elprans in 3bfb574 for #449) * Don't depend on exact syntax errors in tests (by @msullivan in b3ce0c6 for #451) * Fix an error in string representation of RelativeDuration. (by @vpetrovykh in 667da72 for #453) * Add multirange support. (by @vpetrovykh in 15e280e for #452)

vpetrovykh · 2023-07-24T22:34:11Z

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative.

Also add test cases for similar situtation with other duration types.

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

msullivan

Well that is some fun.

It might be worth at some point exposing these hours/minutes/second components directly. Seems a shame to go through all of this trouble only to expose them via string formatting

vpetrovykh · 2023-07-24T23:09:53Z

It might be worth at some point exposing these hours/minutes/second components directly. Seems a shame to go through all of this trouble only to expose them via string formatting

Yeah, we probably want some nice getters or just @property for those at some point.

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

@elprans

Changes ======= * Implement support for new type descriptor protocol (by @elprans in 47eec19 for #427) * Sync errors (by @elprans in 3bfb574 for #449) * Don't depend on exact syntax errors in tests (by @msullivan in b3ce0c6 for #451) * Fix an error in string representation of RelativeDuration. (by @vpetrovykh in 667da72 for #453) * Add multirange support. (by @vpetrovykh in 15e280e for #452)

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

@elprans

Changes ======= * Implement support for new type descriptor protocol (by @elprans in 47eec19 for #427) * Sync errors (by @elprans in 3bfb574 for #449) * Don't depend on exact syntax errors in tests (by @msullivan in b3ce0c6 for #451) * Fix an error in string representation of RelativeDuration. (by @vpetrovykh in 667da72 for #453) * Add multirange support. (by @vpetrovykh in 15e280e for #452)

vpetrovykh · 2023-07-24T22:34:11Z

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative.

Also add test cases for similar situtation with other duration types.

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

msullivan

Well that is some fun.

It might be worth at some point exposing these hours/minutes/second components directly. Seems a shame to go through all of this trouble only to expose them via string formatting

vpetrovykh · 2023-07-24T23:09:53Z

It might be worth at some point exposing these hours/minutes/second components directly. Seems a shame to go through all of this trouble only to expose them via string formatting

Yeah, we probably want some nice getters or just @property for those at some point.

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

@elprans

Changes ======= * Implement support for new type descriptor protocol (by @elprans in 47eec19 for #427) * Sync errors (by @elprans in 3bfb574 for #449) * Don't depend on exact syntax errors in tests (by @msullivan in b3ce0c6 for #451) * Fix an error in string representation of RelativeDuration. (by @vpetrovykh in 667da72 for #453) * Add multirange support. (by @vpetrovykh in 15e280e for #452)

RelativeDuration was getting the '-' for the seconds component wrong in some cases. Specifically, when fractional seconds were 0, but larger units (hours or seconds) were non zero and negative. Also add test cases for similar situtation with other duration types.

@elprans

Changes ======= * Implement support for new type descriptor protocol (by @elprans in 47eec19 for #427) * Sync errors (by @elprans in 3bfb574 for #449) * Don't depend on exact syntax errors in tests (by @msullivan in b3ce0c6 for #451) * Fix an error in string representation of RelativeDuration. (by @vpetrovykh in 667da72 for #453) * Add multirange support. (by @vpetrovykh in 15e280e for #452)

vpetrovykh requested a review from msullivan July 24, 2023 22:34

msullivan approved these changes Jul 24, 2023
View reviewed changes

vpetrovykh merged commit a290b97 into masterJul 24, 2023

vpetrovykh deleted the duration branch July 24, 2023 23:36

aljazerzen mentioned this pull request Feb 23, 2024
v1.9.0 #482
Closed

This was referenced Aug 2, 2024
1.6.1 #513
Closed
edgedb-python 1.6.1 #516
Closed

vpetrovykh requested a review from msullivan July 24, 2023 22:34

msullivan approved these changes Jul 24, 2023
View reviewed changes

vpetrovykh merged commit a290b97 into masterJul 24, 2023

vpetrovykh deleted the duration branch July 24, 2023 23:36

aljazerzen mentioned this pull request Feb 23, 2024
v1.9.0 #482
Closed

This was referenced Aug 2, 2024
1.6.1 #513
Closed
edgedb-python 1.6.1 #516
Closed

vpetrovykh requested a review from msullivan July 24, 2023 22:34

msullivan approved these changes Jul 24, 2023
View reviewed changes

vpetrovykh merged commit a290b97 into masterJul 24, 2023

vpetrovykh deleted the duration branch July 24, 2023 23:36

aljazerzen mentioned this pull request Feb 23, 2024
v1.9.0 #482
Closed

This was referenced Aug 2, 2024
1.6.1 #513
Closed
edgedb-python 1.6.1 #516
Closed

vpetrovykh requested a review from msullivan July 24, 2023 22:34

msullivan approved these changes Jul 24, 2023
View reviewed changes

vpetrovykh merged commit a290b97 into masterJul 24, 2023

vpetrovykh deleted the duration branch July 24, 2023 23:36

aljazerzen mentioned this pull request Feb 23, 2024
v1.9.0 #482
Closed

This was referenced Aug 2, 2024
1.6.1 #513
Closed
edgedb-python 1.6.1 #516
Closed

vpetrovykh requested a review from msullivan July 24, 2023 22:34

msullivan approved these changes Jul 24, 2023
View reviewed changes

vpetrovykh merged commit a290b97 into masterJul 24, 2023

vpetrovykh deleted the duration branch July 24, 2023 23:36

aljazerzen mentioned this pull request Feb 23, 2024
v1.9.0 #482
Closed

This was referenced Aug 2, 2024
1.6.1 #513
Closed
edgedb-python 1.6.1 #516
Closed

vpetrovykh requested a review from msullivan July 24, 2023 22:34

msullivan approved these changes Jul 24, 2023
View reviewed changes

vpetrovykh merged commit a290b97 into masterJul 24, 2023

vpetrovykh deleted the duration branch July 24, 2023 23:36

aljazerzen mentioned this pull request Feb 23, 2024
v1.9.0 #482
Closed

This was referenced Aug 2, 2024
1.6.1 #513
Closed
edgedb-python 1.6.1 #516
Closed

vpetrovykh requested a review from msullivan July 24, 2023 22:34

msullivan approved these changes Jul 24, 2023
View reviewed changes

vpetrovykh merged commit a290b97 into masterJul 24, 2023

vpetrovykh deleted the duration branch July 24, 2023 23:36

aljazerzen mentioned this pull request Feb 23, 2024
v1.9.0 #482
Closed

This was referenced Aug 2, 2024
1.6.1 #513
Closed
edgedb-python 1.6.1 #516
Closed

vpetrovykh requested a review from msullivan July 24, 2023 22:34

msullivan approved these changes Jul 24, 2023
View reviewed changes

vpetrovykh merged commit a290b97 into masterJul 24, 2023

vpetrovykh deleted the duration branch July 24, 2023 23:36

aljazerzen mentioned this pull request Feb 23, 2024
v1.9.0 #482
Closed

This was referenced Aug 2, 2024
1.6.1 #513
Closed
edgedb-python 1.6.1 #516
Closed

Uh oh!

Conversation

vpetrovykh commented Jul 24, 2023

Uh oh!

msullivan left a comment

Choose a reason for hiding this comment

Uh oh!

vpetrovykh commented Jul 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

vpetrovykh commented Jul 24, 2023

Uh oh!

msullivan left a comment

Choose a reason for hiding this comment

Uh oh!

vpetrovykh commented Jul 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

vpetrovykh commented Jul 24, 2023

Uh oh!

msullivan left a comment

Choose a reason for hiding this comment

Uh oh!

vpetrovykh commented Jul 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

vpetrovykh commented Jul 24, 2023

Uh oh!

msullivan left a comment

Choose a reason for hiding this comment

Uh oh!

vpetrovykh commented Jul 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

vpetrovykh commented Jul 24, 2023

Uh oh!

msullivan left a comment

Choose a reason for hiding this comment

Uh oh!

vpetrovykh commented Jul 24, 2023

Uh oh!

Reviewers

Assignees

Labels