Uh oh!
There was an error while loading. Please reload this page.
feat(js): implement bidi actions and flows - #4288
Conversation
Summary of ChangesHello @pavelgj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the framework by introducing comprehensive support for bi-directional actions and flows. This new capability allows for interactive, real-time communication patterns, such as chat-like interfaces, where both the client and the server-side action/flow can send and receive data asynchronously. The changes involve extending core interfaces, adding new functions for defining these bi-directional components, and ensuring robust input and initialization data validation, all backed by new test suites. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and well-implemented feature: support for bidirectional streaming in actions and flows. The changes correctly extend core interfaces like Action, ActionRunOptions, and ActionFnArg to handle streaming inputs and initialization data. The new factory functions bidiAction and bidiFlow are consistent with existing patterns, and the feature is supported by a comprehensive new test suite.
My review focuses on improving type safety by correcting several incomplete or incorrect type assertions in the new implementation. These adjustments will enhance code robustness and maintainability. I've also noted a minor, potentially out-of-scope change in registry.ts and a small typing improvement for a new helper function. Overall, this is a solid contribution.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
pavelgj
commented
Mar 12, 2026
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces significant new functionality by implementing bi-directional actions and flows. The changes are extensive, touching core action and flow definitions, and include new APIs like streamBidi, defineBidiAction, and defineBidiFlow. The addition of init data for actions is also a valuable enhancement. The implementation is well-structured, reusing action to build bidiAction, and bidiAction to build bidiFlow. The accompanying tests are thorough and cover various use cases, including push/pull streaming, init data, and validation. I have a few suggestions to improve code clarity and remove some redundant logic in the core action.ts file.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Code Review
The code changes introduce bi-directional streaming actions and flows, including new interfaces and functions for defining and handling them. The changes include adding BidiStreamingResponse interface, updating Action and ActionFnArg types to support bi-directional streaming, and introducing defineBidiAction and bidiAction functions. The code also updates the FlowConfig interface and introduces defineBidiFlow and bidiFlow functions. The type cast (opts as ActionFnArg<...>) was corrected to directly access opts?.init for type safety.
Uh oh!
There was an error while loading. Please reload this page.
…ectly into `ActionParams` and removing the separate `BidiActionParams` interface.
Remove implicit passing of `input` as `init` for bidi actions and instead use an explicit `init` parameter in the runAction request. Update tests to verify init is passed via its own field and takes precedence over input when both are provided.
- Add missing `Init` type parameter to ActionFnArg cast in action() - Call `registry.initializeAllPlugins()` before running bidi action fn - Remove redundant `init` property already included via spread
Add an optional `init` field to span metadata so action initialization options are captured in traces. When `options.init` is provided, it is serialized and stored as the `genkit:init` span attribute. - Add `init` to SpanMetadataSchema in core tracing and tools types - Serialize and set init metadata in the action runner - Add tests covering init being recorded and omitted
Forward inputStream and init through flow side-channel and store init raw for consistent tracing serialization. Replace null close signal in Channel with a private DONE symbol so legitimate falsy values aren't mistaken for stream end. Surface WebSocket errors and disconnects into in-flight input streams so action bodies fail instead of hanging forever.
Extend flow, defineFlow, and flowAction with an Init type parameter to support init schema and initJsonSchema configuration in flow actions.
Allow findProjectRoot to accept an explicit start directory instead of relying solely on process.cwd(). This makes tests deterministic by avoiding mutation of the process-global cwd, preventing interference when run alongside other tests in the same worker.
Unref the periodic health-check interval so it doesn't keep the process or a Jest worker alive on its own. Also stop the manager in test teardown to clear the timer and allow clean worker exit.
RFC: #4210
Checklist (if applicable):