Skip to content

fix: make git install build lifecycle robust#363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MuncleUscles merged 6 commits into from
Jul 8, 2026
Merged

fix: make git install build lifecycle robust #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c57371d
fix: make git install build script self contained
MuncleUscles Jul 8, 2026
999b911
chore: refresh genlayer-js lockfile
MuncleUscles Jul 8, 2026
b96e4c1
fix: make keychain dependency optional
MuncleUscles Jul 8, 2026
1071c0e
fix: restore git prepare build
MuncleUscles Jul 8, 2026
e98170e
fix: include build dependency for git installs
MuncleUscles Jul 8, 2026
f326b64
chore: keep esbuild as dev dependency
MuncleUscles Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 22 additions & 26 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 6 additions & 4 deletions package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,10 @@
"test:watch": "vitest --watch",
"test:coverage": "vitest run --coverage",
"test:smoke": "vitest run --config vitest.smoke.config.ts",
"dev": "cross-env NODE_ENV=development node esbuild.config.js",
"build": "cross-env NODE_ENV=production node esbuild.config.js",
"dev": "node scripts/run-esbuild.mjs development",
"build": "node scripts/run-esbuild.mjs production",
"prepare": "npm run build",
"prepack": "npm run build",
"release": "./scripts/release.sh",
"postinstall": "node ./scripts/postinstall.js",
"docs:cli": "node scripts/generate-cli-docs.mjs"
Expand DownExpand Up@@ -47,7 +48,6 @@
"@typescript-eslint/eslint-plugin": "^8.0.0",
"@typescript-eslint/parser": "^8.0.0",
"@vitest/coverage-v8": "^3.0.0",
"cross-env": "^7.0.3",
"esbuild": ">=0.25.0",
"eslint": "^9.0.0",
"eslint-config-prettier": "^10.0.0",
Expand All@@ -69,7 +69,6 @@
"fs-extra": "^11.3.0",
"genlayer-js": "github:genlayerlabs/genlayer-js#v2-dev",
"inquirer": "^12.0.0",
"keytar": "^7.9.0",
"node-fetch": "^3.0.0",
"open": "^10.1.0",
"ora": "^8.2.0",
Expand All@@ -78,6 +77,9 @@
"viem": "^2.21.54",
"vitest": "^3.0.0"
},
"optionalDependencies": {
"keytar": "^7.9.0"
},
"overrides": {
"vite": {
"rollup": "npm:@rollup/wasm-node"
Expand Down
12 changes: 12 additions & 0 deletions scripts/run-esbuild.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
#!/usr/bin/env node

const mode = process.argv[2] ?? 'development';

if (!['development', 'production'].includes(mode)) {
console.error(`Unsupported build mode: ${mode}`);
process.exit(1);
}

process.env.NODE_ENV = mode;

await import('../esbuild.config.js');
Loading