Uh oh!
There was an error while loading. Please reload this page.
feat: add --gas to contract deploy and write - #413
Conversation
Expose --gas for deploy and write, keep it separate from GenLayer fee budgets, and pin the genlayer-js commit that provides the corresponding SDK runtime support.
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Delivery context
Depends-On: genlayerlabs/genlayer-js#215
Problem and outcome
Contract deploy/write commands expose GenLayer fee controls but previously offered no way to set the outer EVM transaction gas limit. Large deployment calldata could therefore hit the SDK's old 200,000 fallback and fail with
intrinsic gas too lowbefore GenLayer accepted the transaction.This PR:
--gas <units>togenlayer deployandgenlayer write;bigintas the SDK's top-levelgasoption;869ef09a0a54c2f47a5ecf59a6caa6c2d0db6208, the exact implementation in dependency PR chore: renovate updates #215;This is an organization-owned replacement for #404 and credits @ygd58 for the original CLI gas-option proposal and test approach.
Implementation and validation
npm test -- --run— 808 tests passed against the pinned genlayer-js commit.npm run build— passed.npm run docs:cli— generated and verified the deploy/write references.The full wallet-session suite was run at host level because those tests bind to loopback; its initial sandbox-only failures were all
listen EPERM 127.0.0.1and passed unchanged at host level.Decisions, risks, and rollback
--gasremains a sibling of--fees, not a field inside it: the former controls the outer EVM envelope while the latter controls GenLayer budgets.