Skip to content

[GraphHopper] Add provider parameter - #1251

Open
bisleadity wants to merge 3 commits into
geocoder-php:masterfrom
bisleadity:feature/graphhopper-add-provider
Open

[GraphHopper] Add provider parameter#1251
bisleadity wants to merge 3 commits into
geocoder-php:masterfrom
bisleadity:feature/graphhopper-add-provider

Conversation

@bisleadity

@bisleaditybisleadity commented Mar 21, 2025

Copy link
Copy Markdown

Graphhopper geocoding now supports different providers. Hereby the option is given to use those providers.

As we do need to use one of those providers and there was no possibility given so far I added it.

@jbelienjbelien left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a feature still in development.

The provider parameter is currently under development and can fall back to default at any time.
-- https://docs.graphhopper.com/openapi/geocoding/getgeocode#geocoding/getgeocode/t=request&in=query&path=provider

Comment threadsrc/Provider/GraphHopper/GraphHopper.php
@bisleadity
bisleadityforce-pushed the feature/graphhopper-add-provider branch from 8fedd22 to 4d66689CompareMarch 24, 2025 09:35
@bisleadity
bisleadity requested a review from jbelienMarch 27, 2025 12:25
@bisleadity
bisleadityforce-pushed the feature/graphhopper-add-provider branch from 0fbc0e1 to 320b5d7CompareMarch 28, 2025 09:16
@jbelien

Copy link
Copy Markdown
Member

Could you maybe still add a real test?
Thanks!

@bisleadity

Copy link
Copy Markdown
Author

What's a real test for you?

Graphhopper geocoding supports different providers. Hereby the option is
given to use those providers.
# Conflicts:
#	src/Provider/GraphHopper/CHANGELOG.md
…aphHopper geocoding api
Graphhopper geocoding supports different providers. Hereby the option is given to use only available providers.
[GraphHopper] Add GraphHopperProviders enum for provider options of GraphHopper geocoding api
Graphhopper geocoding supports different providers. Hereby the option is given to use only available providers.
…ns of GraphHopper geocoding api"
This reverts commit 320b5d7.
@bisleadity
bisleadityforce-pushed the feature/graphhopper-add-provider branch from 676a401 to ecb2707CompareJuly 28, 2025 09:43
@func0der

Copy link
Copy Markdown

hey @jbelien Could you elaborate on your "real test" requirement?

I would love to have this feature too.

@jbelien

Copy link
Copy Markdown
Member

@bisleadity Sorry, I mean a test that makes a geocoding request on GraphHopper with the new provider parameter.

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bisleadity@jbelien@func0der