Fix ha_wait to emit herdr 0.8 --until instead of --status - #57
Merged
Conversation
geringforce-pushed
the
task/fix-ha-wait-until-flag
branch
from
September 1, 2026 22:46
359a02f to
a04cd13Compare- Reject leftover --status (flag or value position); never silently translate - Reject --until=S and dangling --until (herdr 0.8 unknown option / would steal --timeout) - Inject herdr's default idle|done|blocked when no --until is given - Pin the argv contract in test_herdr_agent.py - Patch-bump work-system 1.12.0 → 1.12.1 Co-Authored-By: Claude Code <noreply@anthropic.com>
geringforce-pushed
the
task/fix-ha-wait-until-flag
branch
from
September 2, 2026 07:11
a04cd13 to
294f90aCompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
herdr-agent.sh ha_waitwas emitting--status, which herdr 0.8 rejects (unknown option). It now emits--until.--statusis rejected (exit 2), never silently translated — that would hide the same class of flag-name drift.idle/done/blocked). The bounded--timeoutcontract is unchanged.Changes
plugins/work-system/scripts/herdr-agent.sh— flag scan, default--untilinjection,--statusreject path, header/usage docs (valid states + herdr-version-coupled residual; no version probe).plugins/work-system/scripts/test_herdr_agent.py— argv assertions pin--until; default-injection and--statusreject cases.manager-worker-orchestration.md(agent wait --until).plugin.json+marketplace.json+CHANGELOG.md.Note:
delegate-worktree-close-to-manageris also in flight and will bump work-system minor. Version files will collide — whichever PR lands second must rebase and re-resolve the bump.Readiness
ha_wait)check-structure.pypassedTest plan
python3 plugins/work-system/scripts/test_herdr_agent.pypython3 scripts/check-structure.pyherdr agent wait <id> --until idle --timeout 100still accepted;--statusis not.🤖 Generated with Claude Code