Conversation
ymichael
deleted the
bb/2018-acp-cursor-sessions-have-no-bb-dynamic-tool-thr_k6cxqcnuac
branch
August 20, 2026 07:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Cursor ACP applies its project MCP approval gate to client-supplied session MCP servers. ACP has no client permission round trip for that gate, so Cursor rejected the valid
bb-bridgestdio config before spawning it. The same config-advertisement path exists before and after #1834, and the #1932 bootstrap fix remains valid; the missing Cursor approval was the separate root cause.What changed
The ACP bridge now installs the exact bb-owned session MCP fingerprint in the Cursor project approval store before
session/new,session/load, orsession/fork. It limits the workaround tocursor-agentplus thebb-bridgeconfig, preserves existing approvals, serializes concurrent updates, and removes approvals that bb installed when the session ends.The MCP child also reports
initializeback to the bridge, giving host-side diagnostics for both config construction and successful child startup. No server/host-daemon wire contract changed, soHOST_DAEMON_PROTOCOL_VERSIONdoes not need a bump.How you verified
Added fingerprint, approval-file preservation/concurrency, session-lifecycle, and MCP initialize diagnostic regressions. These expose the missing approval before the fix and pass afterward.
pnpm exec turbo run test --filter=bb-plugin-provider-acp --force— 175 passedpnpm exec turbo run typecheck --filter=bb-plugin-provider-acp2026.06.19-20-24-33-653a7fb, with approval installed after ACPinitializeand beforesession/new; Cursor spawned and initialized the MCP serverFixes #2018