Remove the working status from the mobile thread header - #2032
Merged
SawyerHood merged 1 commit intoAug 20, 2026
Merged
Conversation
The header subtitle duplicated the timeline working indicator. The header now hides working-tone statuses and drops the spinner and the unused spinning field. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
🚨 SLOP COP 🚨 · I am the Slop Cop. I am reviewing this pull request for security, code quality, performance, architecture, and mobile behavior. |
SawyerHood
deleted the
bb/remove-thread-header-working-status-thr_vuz28g3ey9
branch
August 20, 2026 14:30
| ): string | null { | ||
| const parts: string[] = []; | ||
| if (statusPill.tone !== "idle") parts.push(statusPill.label); | ||
| if (statusPill.tone !== "idle" && statusPill.tone !== "working") { |
Contributor
There was a problem hiding this comment.
🚨 slopcop/review — This policy change has no direct test. A table test should cover each tone and child label.
Contributor
There was a problem hiding this comment.
🚨 SLOP COP 🚨 · review
Plain English summary: This change removes the mobile header work label because the timeline already shows the same activity.
I found no blocking issue.
One low concern remains. headerSubtitle has no direct policy test. A table test should cover each tone and child label.
- Security: I found no issue. The change only affects React Native display text.
- Performance: The change removes an animated spinner and a wrapper view. It adds no new work.
- Architecture: I found no duplicate filter or stale
spinningname. I do not recommend a larger refactor. - Validation: The exact SHA passed the diff check, mobile type check, and all 813 mobile tests across 119 files.
- End-to-end test: I could not run it. This route is native-only, Maestro is unavailable, and GitHub skipped the iOS flow.
The pull request merged while this review ran.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The mobile thread header showed a "Working" subtitle with a spinner under the title while a thread ran. The timeline already shows a working indicator, so the header line was noise.
What changed
apps/mobile/src/screens/thread/ThreadDetailHeader.tsx:headerSubtitlehides working-tone statuses (Working, Provisioning, Starting, Stopping, Reconnecting). The header keeps "Needs input", "Error", "Waiting for host", "Archived", and the child / side chat label. The spinner is gone.apps/mobile/src/screens/thread/thread-detail-header-model.ts: removed the unusedspinningfield fromThreadStatusPill.How you verified
pnpm exec turbo run typecheck --filter=@bb/mobilepasses.Fixes #