Match mobile unread divider to web styling - #2033
Merged
Merged
Conversation
Use the timeline-accent token, the left-aligned label, and one trailing rule like the web app. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
🚨 SLOP COP 🚨 · I am the SlopCop. I am reviewing this pull request for security, code quality, performance, architecture, and end-to-end behavior. |
Contributor
There was a problem hiding this comment.
🚨 SLOP COP 🚨 · review
Plain English summary: This change makes the mobile New divider match the web divider. It moves the label left and uses the timeline accent color.
I found no defects.
- Security: The change uses static text and static theme classes. It adds no input, network, storage, permission, or execution path.
- Code quality: The mobile text and theme contracts support each new class. The result matches the web label, weight, case, spacing, color, and single rule.
- Architecture: The web and mobile components use different platform elements and list systems. A shared component would add complexity. The shared theme token already provides the useful common contract.
- Performance: The change removes one native View. It does not change list keys, callbacks, scroll work, or memoization.
- Validation: The exact head passed the Turbo mobile type check. All 813 mobile tests passed. Git diff checks and all required GitHub checks passed.
I could not use a browser for the visual check because this row runs in the native React Native app. The optional iOS simulator job did not run. This leaves a small visual test gap, but I found no code risk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The iOS unread divider used the
attentiontoken (yellow), a centered label, and two rules. The web app usestimeline-accent(blue), a left label, and one rule. The two apps did not match.What changed
apps/mobile/src/screens/thread/timeline/TimelineList.tsx: the divider now usestext-timeline-accent/bg-timeline-accent, an uppercase medium-weight "New" label on the left, and one rule on the right. This matchesUnreadDividerinapps/app/src/components/thread/timeline/ThreadTimelineRows.tsx.How you verified
pnpm exec turbo run typecheck --filter=@bb/mobilepasses. Visual change only; no new tests.