Separate timeline head state from conversation context - #3876
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Latest plan/goal snapshots were inserted into conversation context before its bounds were calculated. An old plan could pull thousands of unrelated turn markers into a small current page. Projecting that snapshot as a partial historical turn also made current row ordering depend on unrelated head state.
What changed
Load latest head state separately and use it only for plan/goal extraction. Conversation events determine context bounds, grouping, and pagination. Include head-state rows in selection-cache byte accounting.
Stacked on #3874; this PR contains only the head-state separation.
How you verified
olderRowsSourceSeqEnd, because auxiliary historical snapshots no longer participate in conversation projection. One already-deleted thread returns the same 404.