Skip to content

Consolidate machine installation on bootstrap enrollment - #3940

Open
ymichael wants to merge 1 commit into
mainfrom
bb/machine-enrollment-over-bb-connect-needs-a-mobil-thr_gqq7qfe7nz
Open

ymichael wants to merge 1 commit into
mainfrom
bb/machine-enrollment-over-bb-connect-needs-a-mobil-thr_gqq7qfe7nz

Conversation

@ymichael

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

Machine installation exposed both a bootstrap enrollment flow and a separate join-code flow with its own Connect credential redemption. The CLI also issued bare join codes even though enrolling a fresh machine required additional identity and server details.

What changed

  • Require a private bootstrap bundle for installer enrollment and delegate enrollment to bb machine enroll.
  • Remove bb machine join-code and the installer’s --join-code, --machine-code, and --server flags. Document bb machine create --provider manual and running its printed command on the target machine.
  • Preserve bb.sdk.hosts.createJoinCode(), its return types, and the HTTP endpoint for existing plugins. Mark the SDK method deprecated with guidance toward bootstrap enrollment.
  • Adapt installer tests and verification recipes to bootstrap enrollment. Daemon wire contracts are unchanged.

How you verified

  • pnpm exec turbo run test --filter=@bb/server -- test/app/install-machine-script.test.ts — 36 tests passed. The progress test exercises all 60 readiness probes with a 15-second timeout.

  • pnpm exec turbo run test --filter=@bb/sdk --filter=@bb/server-contract — 192 tests passed.

  • pnpm exec turbo run test --filter=@bb/server -- test/public/public-host-management.test.ts — 12 tests passed.

  • pnpm exec turbo run typecheck --filter=@bb/cli --filter=@bb/sdk — passed.

  • sh -n apps/server/src/assets/install-machine.sh and git diff --check — passed.

AGENT GENERATED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant