Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Machine installation exposed both a bootstrap enrollment flow and a separate join-code flow with its own Connect credential redemption. The CLI also issued bare join codes even though enrolling a fresh machine required additional identity and server details.
What changed
bb machine enroll.bb machine join-codeand the installer’s--join-code,--machine-code, and--serverflags. Documentbb machine create --provider manualand running its printed command on the target machine.bb.sdk.hosts.createJoinCode(), its return types, and the HTTP endpoint for existing plugins. Mark the SDK method deprecated with guidance toward bootstrap enrollment.How you verified
pnpm exec turbo run test --filter=@bb/server -- test/app/install-machine-script.test.ts— 36 tests passed. The progress test exercises all 60 readiness probes with a 15-second timeout.pnpm exec turbo run test --filter=@bb/sdk --filter=@bb/server-contract— 192 tests passed.pnpm exec turbo run test --filter=@bb/server -- test/public/public-host-management.test.ts— 12 tests passed.pnpm exec turbo run typecheck --filter=@bb/cli --filter=@bb/sdk— passed.sh -n apps/server/src/assets/install-machine.shandgit diff --check— passed.