Improve open in editor remote support - #403
Merged
Merged
Conversation
ymichael
marked this pull request as ready for review
June 26, 2026 03:30
ymichael
force-pushed
the
bb/open-in-editor-remote-support-thr_r2td3th8i8
branch
2 times, most recently
from
June 26, 2026 03:44
81752b7 to
671b763
Compare
ymichael
force-pushed
the
bb/open-in-editor-remote-support-thr_r2td3th8i8
branch
from
June 26, 2026 18:06
9014303 to
d5eac13
Compare
SawyerHood
pushed a commit
that referenced
this pull request
Aug 28, 2026
## Summary - restrict generic Linux desktop-entry discovery to file managers, text editors, and terminal emulators - use the standard XDG `Categories` values `FileManager`, `TextEditor`, and `TerminalEmulator` - keep unrelated desktop applications out of BB's Open in/Open with menus ## Root cause PR #403 added generic Linux desktop-application discovery for workspace open targets. It currently includes every visible `.desktop` entry with `Type=Application`, an `Exec` command, and neither `Hidden=true` nor `NoDisplay=true`. As a result, BB's Open in/Open with menus can contain nearly every installed desktop application on Linux, including media players, settings utilities, messaging clients, and other software that is not a useful workspace target. This change additionally requires a relevant standard XDG category: `FileManager`, `TextEditor`, or `TerminalEmulator`. Existing explicit BB launch adapters remain unaffected. ## Validation - `pnpm exec turbo run typecheck test --filter=@bb/local-open-targets --force` - `git diff --check` > AGENT GENERATED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bb-app client ssh-targetstored in<dataDir>/client.jsonValidation
pnpm exec turbo run typecheck test --filter=@bb/local-open-targets --cache-dir=.turbo/cache --output-logs=new-onlypnpm exec turbo run typecheck lint build --filter=@bb/app --cache-dir=.turbo/cache --output-logs=new-onlygit diff --checkpnpm exec turbo run typecheck --filter=@bb/config --filter=@bb/host-daemon-contract --filter=@bb/host-daemon --filter=bb-app --filter=@bb/templates --forcepnpm exec turbo run test --filter=@bb/config --filter=@bb/host-daemon-contract --filter=@bb/host-daemon --filter=bb-app --force -- test/client-config.test.ts test/contract.test.ts src/local-api.test.ts src/workspace-open-targets.test.ts test/index.test.tspnpm exec turbo run test --filter=@bb/templates --forcepnpm exec turbo run build --filter=bb-app --force