chore(ci): Migrate from Travis to GH actions

.github/workflows/ci.yml

@@ -0,0 +1,97 @@
+name: CI
+
+on:
+ push:
+ branches: [master]
+ pull_request:
+
+jobs:
+ test:
+ runs-on: ubuntu-22.04
+
+ services:
+ postgres:
+ image: postgres:16
+ env:
+ POSTGRES_USER: travis
+ POSTGRES_HOST_AUTH_METHOD: trust
+ options: >-
+ --health-cmd pg_isready
+ --health-interval 10s
+ --health-timeout 5s
+ --health-retries 5
+ ports:
+ - 5432:5432
+
+ strategy:
+ fail-fast: false
+ matrix:
+ ruby: ['3.0', '3.1', '3.2', '3.3']
+
+ env:
+ PGPORT: 5432
+ PGUSER: travis
+ PGHOST: localhost
+
+ steps:
+ - uses: actions/checkout@v4
+
+ - uses: ruby/setup-ruby@v1
+ with:
+ ruby-version: ${{ matrix.ruby }}
+ bundler-cache: true
+
+ - uses: actions/setup-node@v4
+ with:
+ node-version: lts/*
+ cache: 'yarn'
+
+ - name: Run tests
+ run: bundle exec rake test
+
+ release:
+ needs: test
+ runs-on: ubuntu-22.04
+ if: github.ref == 'refs/heads/master'
+
+ permissions:
+ contents: write
+ id-token: write # required for RubyGems trusted publishing
+
+ steps:
+ - name: Generate GitHub App token
+ id: app-token
+ uses: actions/create-github-app-token@v1
+ with:
+ app-id: ${{ secrets.RELEASE_BOT_APP_ID }}
+ private-key: ${{ secrets.RELEASE_BOT_PRIVATE_KEY }}
+
+ - uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ token: ${{ steps.app-token.outputs.token }}
+
+ - uses: ruby/setup-ruby@v1
+ with:
+ ruby-version: '3.0'
+ bundler-cache: true
+
+ - uses: actions/setup-node@v4
+ with:
+ node-version: lts/*
+
+ - name: Install semantic-release
+ run: |
+ npm i -g \
+ semantic-release \
+ @semantic-release/git \
+ @semantic-release/changelog \
+ semantic-release-rubygem
+
+ - name: Configure RubyGems credentials
+ uses: rubygems/configure-rubygems-credentials@v1
+
+ - name: Release
+ env:
+ GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}
+ run: ./release.sh

README.md

@@ -22,7 +22,7 @@ granular than a full debug trace. It's designed to be optimal for understanding
 Visit the [AppMap for Ruby](https://appland.com/docs/reference/appmap-ruby.html) reference page on AppLand.com for a complete reference guide.
 
 # Development
-[![Build Status](https://travis-ci.com/getappmap/appmap-ruby.svg?branch=master)](https://travis-ci.com/getappmap/appmap-ruby)
+[![CI](https://github.com/getappmap/appmap-ruby/actions/workflows/ci.yml/badge.svg)](https://github.com/getappmap/appmap-ruby/actions/workflows/ci.yml)
 
 ## Internal architecture
 

README_CI.md

@@ -1,17 +1,17 @@
 # Configuration variables:
 
-* `GH_TOKEN`: used by `semantic-release` to push changes to Github and manage releases
-* `GEM_HOST_API_KEY`: rubygems API key
-* `GEM_ALTERNATIVE_NAME` (optional): used for testing of CI flows,
+* `RELEASE_BOT_APP_ID`, `RELEASE_BOT_PRIVATE_KEY`: GitHub App credentials used to generate a token for `semantic-release` to push changes to GitHub and manage releases
+* RubyGems publishing uses OIDC trusted publishing — no API key required
+* `GEM_ALTERNATIVE_NAME` (optional): used for testing of CI flows,
 to avoid publication of test releases under official package name
 
 # Release command
 
-`./release.sh`
+`./release.sh`
 
-Bash wrapper script is used merely as a launcher of `semantic-release`
-with extra logic to explicitly determine git url from `TRAVIS_REPO_SLUG` \
-variable if its defined (otherwise git url is taken from `package.json`,
+Bash wrapper script is used merely as a launcher of `semantic-release`
+with extra logic to explicitly determine git url from `GITHUB_REPOSITORY` \
+variable if it's defined (otherwise git url is taken from `package.json`,
 which breaks CI on forked repos).
 
 # CI flow

lib/appmap/depends/test_runner.rb

@@ -37,7 +37,9 @@ def normalize_test_files(test_files)
 
  def test_env
  # DISABLE_SPRING because it's likely to not have APPMAP=true
- { 'RAILS_ENV' => 'test', 'APPMAP' => 'true', 'DISABLE_SPRING' => '1' }
+ ruby_bin = File.dirname(RbConfig.ruby)
+ path = [ruby_bin, ENV['PATH']].join(File::PATH_SEPARATOR)
+ { 'RAILS_ENV' => 'test', 'APPMAP' => 'true', 'DISABLE_SPRING' => '1', 'PATH' => path }
  end
 
  def simplify_path(file)

lib/appmap/open.rb

@@ -33,20 +33,30 @@ def page
  PAGE
  end
 
- def run_server
+ def run_server(timeout: 10)
  require 'rack'
- Thread.new do
+thread = Thread.new do
  Rack::Handler::WEBrick.run(
  lambda do |env|
  [200, { 'Content-Type' => 'text/html' }, [page]]
  end,
- :Port => 0
+ Port: 0,
+ BindAddress: "127.0.0.1"
  ) do |server|
  @port = server.config[:Port]
  end
- end.tap do
- sleep 1.0
  end
+ deadline = Process.clock_gettime(Process::CLOCK_MONOTONIC) + timeout
+ sleep 0.1 until @port || !thread.alive? || Process.clock_gettime(Process::CLOCK_MONOTONIC) >= deadline
+
+ unless thread.alive?
+ thread.value # re-raise any exception from the server thread
+ raise "Server thread exited unexpectedly"
+ end
+
+ return thread if @port
+
+ raise "Timed out waiting for server to start after #{timeout} s"
  end
 
  def open_browser

lib/appmap/service/test_framework_detector.rb

@@ -5,15 +5,23 @@ module Service
  class TestFrameworkDetector
  class << self
  def rspec_present?
-Gem.loaded_specs.has_key?('rspec-core')
+gem_available?('rspec-core')
  end
 
  def minitest_present?
-Gem.loaded_specs.has_key?('minitest')
+gem_available?('minitest')
  end
 
  def cucumber_present?
- Gem.loaded_specs.has_key?('cucumber')
+ gem_available?('cucumber')
+ end
+
+ private
+
+ def gem_available?(name)
+ Gem.loaded_specs.has_key?(name) || !Gem::Specification.find_by_name(name).nil?
+ rescue Gem::MissingSpecError
+ false
  end
  end
  end

lib/appmap/swagger/markdown_descriptions.rb

@@ -1,4 +1,3 @@
-require 'rdoc'
 require 'reverse_markdown'
 
 module AppMap
@@ -32,6 +31,7 @@ def perform
  protected
 
  def rdoc_to_markdown(comment)
+ require 'rdoc'
  # Strip tags
  comment = comment.split("\n").reject { |line| line =~ /^\s*@/ }.join("\n")
  converter = ::RDoc::Markup::ToHtml.new(::RDoc::Options.new)

release.sh

@@ -1,10 +1,10 @@
 #!/bin/bash
-# using bash wrapper as Rake blows up in `require/extentiontask` (line 10)
+# using bash wrapper as Rake blows up in `require/extensiontask` (line 10)
 
 RELEASE_FLAGS=""
-if [ ! -z "$TRAVIS_REPO_SLUG" ]; then
- RELEASE_FLAGS="-r git+https://github.com/${TRAVIS_REPO_SLUG}.git"
-fi
+if [ ! -z "$GITHUB_REPOSITORY" ]; then
+ RELEASE_FLAGS="-r git+https://github.com/${GITHUB_REPOSITORY}.git"
+fi
 
 if [ ! -z "$GEM_ALTERNATIVE_NAME" ]; then
  echo "Release: GEM_ALTERNATIVE_NAME=$GEM_ALTERNATIVE_NAME"

spec/depends/api_spec.rb

@@ -14,13 +14,13 @@ def rspec_environment_method
  end
 
  def minitest_test_command(test_files)
- "time bundle exec ruby -rminitest -Itest #{test_files}"
+ "bundle exec ruby -rminitest -Itest #{test_files}"
  end
 
  alias minitest_test_command_method minitest_test_command
 
  def rspec_test_command_method(test_files)
- "time bundle exec rspec #{test_files}"
+ "bundle exec rspec #{test_files}"
  end
 
  def rspec_select_tests_method(test_files)

spec/fixtures/rails6_users_app/Gemfile

@@ -12,6 +12,11 @@ gem 'sequel', '>= 5.43.0', require: false
 gem 'sequel-rails', require: false
 gem 'sequel_secure_password', require: false
 
+# pin to avoid uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger
+gem 'concurrent-ruby', '1.3.4'
+
+gem 'mutex_m'
+
 group :development, :test do
  gem 'appmap', path: '../../..'
  gem 'cucumber-rails', require: false

spec/fixtures/rails6_users_app/spec/rails_helper.rb

@@ -43,15 +43,22 @@
  # arbitrary gems may also be filtered via:
  # config.filter_gems_from_backtrace("gem name")
 
- DatabaseCleaner.allow_remote_database_url = true
-
- config.before(:suite) do
- DatabaseCleaner.strategy = :transaction
- end
+ if ENV['ORM_MODULE'] == 'activerecord'
+ # ActiveRecord participates in Rails transaction rollback automatically
+ config.use_transactional_fixtures = true
+ else
+ # Sequel doesn't use AR transactions, so use DatabaseCleaner truncation
+ DatabaseCleaner.allow_remote_database_url = true
+ config.use_transactional_fixtures = false
+
+ config.before(:suite) do
+ DatabaseCleaner[:sequel].strategy = :truncation
+ end
 
- config.around :each do |example|
- DatabaseCleaner.cleaning do
- example.run
+ config.around :each do |example|
+ DatabaseCleaner[:sequel].cleaning do
+ example.run
+ end
  end
  end
 end

spec/fixtures/rails7_users_app/spec/rails_helper.rb

@@ -43,15 +43,22 @@
  # arbitrary gems may also be filtered via:
  # config.filter_gems_from_backtrace("gem name")
 
- DatabaseCleaner.allow_remote_database_url = true
-
- config.before(:suite) do
- DatabaseCleaner.strategy = :transaction
- end
+ if ENV['ORM_MODULE'] == 'activerecord'
+ # ActiveRecord participates in Rails transaction rollback automatically
+ config.use_transactional_fixtures = true
+ else
+ # Sequel doesn't use AR transactions, so use DatabaseCleaner truncation
+ DatabaseCleaner.allow_remote_database_url = true
+ config.use_transactional_fixtures = false
+
+ config.before(:suite) do
+ DatabaseCleaner[:sequel].strategy = :truncation
+ end
 
- config.around :each do |example|
- DatabaseCleaner.cleaning do
- example.run
+ config.around :each do |example|
+ DatabaseCleaner[:sequel].cleaning do
+ example.run
+ end
  end
  end
 end