Skip to content

fixing performance bug in Perl implementation - #68

Open
getify wants to merge 6 commits into
perlfrom
fix-perf-perl
Open

fixing performance bug in Perl implementation#68
getify wants to merge 6 commits into
perlfrom
fix-perf-perl

Conversation

@getify

@getifygetify commented Dec 15, 2021•
edited
Loading

Copy link
Copy Markdown
Owner

See #64

NOTE: this is not yet ready, as there's still a FIXME to resolve on this line: f80d978#diff-67dad0d447d0301fffaaab6e42c4cf7129200818c5edbf19531fd115eb2f098bR127

yurikhan
yurikhan reviewed Dec 15, 2021
View reviewed changes
Comment threadjson_minify/lib/JSON_minify.pm Outdated
@getifygetify mentioned this pull request Dec 15, 2021
Open
@getify

getify commented Dec 15, 2021

Copy link
Copy Markdown
OwnerAuthor

Hmmm, so seems tests are failing here? Bummer.

@yurikhan

yurikhan commented Dec 15, 2021

Copy link
Copy Markdown

Ha, yes. substr expects its third argument to specify substring length, not end position.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@yurikhanyurikhanyurikhan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@getify@yurikhan