Uh oh!
There was an error while loading. Please reload this page.
docs(testing): log the 2026-07-19b/c RC follow-up passes on rc.3 - #131
docs(testing): log the 2026-07-19b/c RC follow-up passes on rc.3#131EtienneLescot wants to merge 3 commits into
Conversation
Results log entry for the follow-up v1.7.0-rc.3 pass: automated tests (typecheck/lint/unit/browser/e2e/i18n) plus a code review of the RC-window commits, run without a computer-use tool or reachable GUI session, so none of the manual checklist items from the prior Windows pass were re-verified. Surfaces a pre-existing (not RC-introduced) i18n:check failure found along the way. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Follow-up to the automated-only 2026-07-19b pass now that a computer-use tool became available: installed and ran the real signed rc.3 .dmg (checksum-verified against the GitHub Release digest) and closed nearly every gap left open by the prior Windows and automated-only passes. Confirms macOS issue #21 (shutdown-path crash) does not reproduce across repeated rapid record/stop cycles. Files two new bugs found along the way: stale/nonexistent testids in windows-native-checklist.spec.ts (#130), and corrects the checklist's own "highlight cursor mode" wording (no such mode exists — the real toggle is editable-overlay vs system). Remaining gaps (tray icon, webcam mirroring/reactive zoom, Spaces switch) are blocked by environment/hardware limits, not reproduced defects. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release-candidate E2E checklist records revised audio, webcam, timeline, and macOS validation results, including environment limitations, automated checks, and follow-up issues. ChangesRC E2E validation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/testing/rc-e2e-checklist.md`:
- Line 54: Update the checklist item title in the cursor telemetry section to
replace the obsolete “highlight/spotlight” terminology with “editable cursor
telemetry overlay,” while preserving the existing validation details and
behavior.
- Line 34: Correct the checklist entry so it does not mark the launch-window
video-opening criterion as passed based on the separate Open Studio flow. Leave
the launch-window criterion unchecked or split it into distinct items, and mark
only the HUD → Open Studio → editor empty state → Import Video File path as
verified; retain the missing-control/test discrepancy as an issue.
- Line 45: Update the system-audio-only checklist item to avoid claiming audible
playback based solely on the waveform spike. Either leave the playback item
unchecked or rename it to describe capture-signal evidence only, and retain the
supporting recording details without asserting verified audibility.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 44262b15-9dda-43ef-872b-19fdfed31e6a
📒 Files selected for processing (1)
docs/testing/rc-e2e-checklist.md
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Don't check "opening video from the launch window" when the actual button doesn't exist there; split into the unverified literal item (still open, tracked by #130) and the verified real path (HUD -> Open Studio -> Import Video File). - Don't equate a captured waveform spike with confirmed audible playback for the system-audio-only item; leave unchecked since this pass had no audio-playback capability to confirm audibility itself. - Rename the cursor telemetry checklist item away from the nonexistent "highlight/spotlight" terminology to "editable cursor telemetry overlay", matching what the codebase actually calls it.
Summary
Two follow-up passes on the
docs/testing/rc-e2e-checklist.mdRC checklist forv1.7.0-rc.3, continuing from the 2026-07-19 Windows pass already logged in the Results log:v1.7.0-rc.3packaged.dmg(not a dev build), closing nearly every gap left open by the prior passes.Findings
npm run i18n:checkfails with ~50 missing/extra translation keys; confirmed pre-existing debt, not an rc.3 regression.windows-native-checklist.spec.tsreferences two testids that don't exist anywhere inLaunchWindow.tsx; the spec has apparently never actually executed since it self-skips off-Windows and CI is Linux-only.editable-overlayvssystem.Targeted at
mainper the release-branch-freeze contract in.harness/docs/git-workflow.md(docs don't need cherry-picking to the release branch).Summary by CodeRabbit