Uh oh!
There was an error while loading. Please reload this page.
fix(nix): make the v1.8.0 tag buildable - #231
Conversation
…ers get promote.yml pushes the stable tag on this branch's tip, and nix/package.nix here still carries what v1.6.0 left on 2026-07-05. `src` is the repo tree rather than a fetched tarball, so `nix run github:…/v1.8.0` builds this file and would refuse the mismatch on sight. bump-nix-package.yml cannot cover it: it fires after the release is published, reads main, and opens its PR against main — the tag is never in its path. So the hash has to be right here, before the tag is cut. package-lock.json is byte-identical between this branch and main, so the value is the one CI computed on main in run 30789963366, not a fresh guess: sha256-SggSPoDnKzmvgXpIGP11y6h390SkoZszeMjFTaokRjQ= Version goes straight to 1.8.0 — promote rewrites package.json at tag time but never touches this file. With both lines correct here, the bump workflow finds nothing to change after the release and no-ops, which is the intended resting state rather than a repair.
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
Targets
release/v1.8.0, not main — nothing from main comes along.Why the fix on main isn't enough
srcinnix/package.nixis this repo's own tree, not a tarball fetched at a tag. So what a Nix user builds depends on the ref they point at:nix run github:getopenscreen/openscreennix run github:getopenscreen/openscreen/v1.8.0And
promote.ymlpushes the stable tag on the release branch tip:So
v1.8.0would ship thenix/package.nixthis branch currently carries, untouched since 2026-07-05:bump-nix-package.ymlstructurally cannot repair that. It fires onrelease: published, checks out main, and opens its PR against main. The tag is never on its path — it has never once touched a tag.The value is already proven, not guessed
package-lock.jsonis byte-identical between this branch and main:So the correct hash is exactly what CI computed on main in run 30789963366:
Version
Straight to
1.8.0.promote.ymlrewritespackage.jsonat tag time but never touchesnix/package.nix.With both lines correct here,
bump-nix-package.ymlhits itsgit diff --quietearly-exit after the release and no-ops — the workflow becomes a safety net rather than the thing doing the repair after the fact.Merging this back into main is safe
promote.ymlrebase-merges this branch into main afterwards. No commit on this branch touchesnix/other than this one:So main keeps whatever #230 leaves it with, and this lands on top with the same hash.
Depends on nothing
Independent of #230. #230 fixes main and stops the drift recurring; this makes the v1.8.0 tag buildable. Both are wanted, in either order.