Uh oh!
There was an error while loading. Please reload this page.
test(media): inject the failed registry write instead of chmod-ing the temp dir - #280
Merged
Merged
Conversation
…e temp dir "logs a refresh it cannot write" arranged its failure with `chmod(tempDir, 0o555)`. That is not a portable way to make a write fail: on Windows the bit lands on a directory attribute that does not stop a file being created inside, so the refresh succeeded, nothing warned, and the case failed on every Windows dev machine. `skipIf(process.getuid?.() === 0)` could not catch it either — `getuid` is undefined there, so the guard read as "not root" and ran anyway. CI only runs the suite on ubuntu-latest, so this stayed green there while being permanently red locally — which is the worst shape a test can have: it teaches you to skim past a red suite on the machine the app is actually developed on. The write is now failed by injection (`vi.spyOn(fs, "writeFile")`), which asserts the same thing on every platform and at any privilege level, and the spy is asserted to have been called so the case cannot pass with the refresh path deleted. Verified by ablation: dropping the `.catch()` in findMediaLinksByFingerprint still turns it red, with the rejection escaping as the unhandled one it exists to prevent.
Uh oh!
There was an error while loading. Please reload this page.
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe refresh failure test now mocks ChangesMedia refresh failure handling
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"logs a refresh it cannot write" arranged its failure with
chmod(tempDir, 0o555). That is not a portable way to make a write fail: on Windows the bitlands on a directory attribute that does not stop a file being created inside,
so the refresh succeeded, nothing warned, and the case failed on every Windows
dev machine.
skipIf(process.getuid?.() === 0)could not catch it either —getuidis undefined there, so the guard read as "not root" and ran anyway.CI only runs the suite on ubuntu-latest, so this stayed green there while being
permanently red locally — which is the worst shape a test can have: it teaches
you to skim past a red suite on the machine the app is actually developed on.
The write is now failed by injection (
vi.spyOn(fs, "writeFile")), whichasserts the same thing on every platform and at any privilege level, and the
spy is asserted to have been called so the case cannot pass with the refresh
path deleted. Verified by ablation: dropping the
.catch()infindMediaLinksByFingerprint still turns it red, with the rejection escaping as
the unhandled one it exists to prevent.
Summary by CodeRabbit