Uh oh!
There was an error while loading. Please reload this page.
fix(layout): show no-webcam for camera-less projects - #310
Conversation
Warning Review limit reached
Next review available in:25 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesCamera-aware layout handling
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/ai-edition/RightPanes.layout.test.tsx`:
- Around line 67-88: The “LayoutPane camera availability” tests need to cover
all camera-dependent UI behavior when no camera is available. Extend the
no-camera case to assert reactive zoom and webcam size are hidden, and verify
the remaining camera-dependent controls are disabled; keep the existing
saved-preset assertions unchanged and add coverage in this test file for each
new branch.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f87047f2-ff91-4d9d-9804-be27ca140d0b
📒 Files selected for processing (2)
src/components/ai-edition/RightPanes.layout.test.tsxsrc/components/ai-edition/RightPanes.tsx
Uh oh!
There was an error while loading. Please reload this page.
Summary
No Webcamstate for camera-less timelines, matching preview/export behaviorThis completes the remaining UI portion of #248 after the renderer/export correction merged in #261.
Related issue
Fixes#248
Type of change
Release impact
Desktop impact
Screenshots / video
Not included; DOM regression coverage verifies both camera-less and camera-present states.
Testing
picture-in-picturewas displayed)npx vitest --run src/components/ai-edition/RightPanes.layout.test.tsx src/components/ai-edition/RightPanes.i18n.test.tsx(7 passed)npm run test(1,679 passed, 1 skipped across 141 files)npx tsc --noEmitnpx tsc -p tsconfig.test.json --noEmitnpx biome check src/components/ai-edition/RightPanes.tsx src/components/ai-edition/RightPanes.layout.test.tsxnpm run docs:checknpm run i18n:checknpm run build-viteAuthored with Codex assistance and manually verified against the remaining #248 UI behavior.
Summary by CodeRabbit