Skip to content

Fix warning test query - #6335

Merged
gaecoli merged 2 commits into
masterfrom
fix-warning/test-query
Aug 1, 2023
Merged

Fix warning test query#6335
gaecoli merged 2 commits into
masterfrom
fix-warning/test-query

Conversation

@konnectr

@konnectrkonnectr commented Aug 1, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

python/cpython#28268

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@gaecoli

gaecoli commented Aug 1, 2023

Copy link
Copy Markdown
Member

Can you put warning text at there?

@konnectr

konnectr commented Aug 1, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Can you put warning text at there?

tests/handlers/test_queries.py::TestQueryListResourcePost::test_create_query
/usr/local/lib/python3.8/unittest/case.py:1215: DeprecationWarning: assertDictContainsSubset is deprecated
warnings.warn('assertDictContainsSubset is deprecated',

gaecoli
gaecoli reviewed Aug 1, 2023
View reviewed changes

@gaecoligaecoli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But I think our test style tends to use set() to get the result container. Is it possible not to change the method of set([xxx]), If the new form is used first, I agree!

@gaecoli
gaecoli merged commit 196bfec into masterAug 1, 2023
@justinclift
justinclift deleted the fix-warning/test-query branch August 1, 2023 11:12
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Jan 8, 2025
@konnectr@harveyrendell
Fix warning test query (getredash#6335)
426bfcf
* replace assertDictContainsSubset -> asserLessEqual
* refactor definition set
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaecoligaecoligaecoli left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@konnectr@gaecoli